Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix examples in tutorial and api gw handler #1013

Closed
michaelbrewer opened this issue Feb 8, 2022 · 2 comments
Closed

docs: fix examples in tutorial and api gw handler #1013

michaelbrewer opened this issue Feb 8, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@michaelbrewer
Copy link
Contributor

michaelbrewer commented Feb 8, 2022

What were you initially searching for in the docs?

  • Working code examples.

Is this related to an existing part of the documentation? Please share a link

Describe how we could make it clearer

  • Fix code examples

If you have a proposed update, please share it here

List of things to fix:

  • fix line number highlights
  • fix missing imports
  • fix syntax error
  • fix indents
  • fix example code rendering

Indent issue example:
Screen Shot 2022-02-07 at 10 17 20 PM

Syntax Error example:
Screen Shot 2022-02-07 at 10 20 59 PM

Missing import example for json example:
Screen Shot 2022-02-07 at 10 22 54 PM

Code rendering example:
Screen Shot 2022-02-07 at 10 23 59 PM

PR:

@michaelbrewer michaelbrewer added the documentation Improvements or additions to documentation label Feb 8, 2022
@michaelbrewer michaelbrewer changed the title fix examples docs: fix examples in tutorial and api gw handler Feb 8, 2022
@heitorlessa heitorlessa added the pending-release Fix or implementation already in dev waiting to be released label Feb 9, 2022
@heitorlessa
Copy link
Contributor

now available as part of 1.25.0 release

@github-actions
Copy link
Contributor

This is now released under 1.25.10 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants