Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Serveless Framework example #1363

Merged
merged 29 commits into from
Sep 28, 2023

Conversation

AlexeySoshin
Copy link
Contributor

Issue #, if available:
#1067

Description of changes:

Adding Serverless Framework example

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AlexeySoshin AlexeySoshin marked this pull request as ready for review August 14, 2023 14:10
Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to change. Please make sure they are also applied to the example you've already pushed. See you soon!

@scottgerring
Copy link
Contributor

Can you tie this to the CI/CD process somehow too - is there some way to build or lint the serverless project so we know we've broken it?

@scottgerring
Copy link
Contributor

scottgerring commented Aug 15, 2023

We're missing a link in examples/powertools-examples-core/README.md and in examples/README.md

https://github.com/AlexeySoshin/powertools-lambda-java/tree/serverless-example/examples/powertools-examples-core

"We provide examples for the following" ...

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments inline!

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost ok!

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me!

@jeromevdl
Copy link
Contributor

@scottgerring if you want to check as you required some changes...

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scottgerring
Copy link
Contributor

@scottgerring if you want to check as you required some changes...

will check this morning 👍

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @AlexeySoshin !

@scottgerring scottgerring merged commit 4d3484f into aws-powertools:main Sep 28, 2023
12 checks passed
jeromevdl added a commit that referenced this pull request Oct 12, 2023
* Initial

* Add memory size and timeouts, same as SAM examples

* Add useful Serverless commands

* Remove redundant function

* Update examples/powertools-examples-core/serverless/README.md

Co-authored-by: Scott Gerring <[email protected]>

* Update examples/powertools-examples-core/serverless/README.md

Co-authored-by: Scott Gerring <[email protected]>

* Update examples/powertools-examples-core/serverless/README.md

Co-authored-by: Scott Gerring <[email protected]>

* Update examples/powertools-examples-core/serverless/README.md

Co-authored-by: Scott Gerring <[email protected]>

* Update examples/powertools-examples-core/serverless/README.md

Co-authored-by: Scott Gerring <[email protected]>

* Remove reduntant command from README

* Move most of Powertools configuration to the service-wide environment

* Remove more generated comments

* Add newlines

* Comment out annotations that are preceded by environment variables

* Add link to the Serverless example

* Update examples/powertools-examples-core/serverless/pom.xml

Co-authored-by: Jérôme Van Der Linden <[email protected]>

* Update examples/powertools-examples-core/serverless/pom.xml

Co-authored-by: Jérôme Van Der Linden <[email protected]>

* Update examples/powertools-examples-core/serverless/pom.xml

Co-authored-by: Jérôme Van Der Linden <[email protected]>

* Remove POWERTOOLS_LOGGER_LOG_EVENT, since it's unsupported

---------

Co-authored-by: Scott Gerring <[email protected]>
Co-authored-by: Jérôme Van Der Linden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants