-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Serveless Framework example #1363
docs: Add Serveless Framework example #1363
Conversation
examples/powertools-examples-core/serverless/src/main/java/helloworld/App.java
Outdated
Show resolved
Hide resolved
examples/powertools-examples-core/serverless/src/main/java/helloworld/App.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to change. Please make sure they are also applied to the example you've already pushed. See you soon!
Can you tie this to the CI/CD process somehow too - is there some way to build or lint the serverless project so we know we've broken it? |
We're missing a link in "We provide examples for the following" ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments inline!
Co-authored-by: Scott Gerring <[email protected]>
Co-authored-by: Scott Gerring <[email protected]>
Co-authored-by: Scott Gerring <[email protected]>
Co-authored-by: Scott Gerring <[email protected]>
…ambda-java into serverless-example
Co-authored-by: Scott Gerring <[email protected]>
…ambda-java into serverless-example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost ok!
Co-authored-by: Jérôme Van Der Linden <[email protected]>
Co-authored-by: Jérôme Van Der Linden <[email protected]>
Co-authored-by: Jérôme Van Der Linden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good for me!
@scottgerring if you want to check as you required some changes... |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
will check this morning 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @AlexeySoshin !
* Initial * Add memory size and timeouts, same as SAM examples * Add useful Serverless commands * Remove redundant function * Update examples/powertools-examples-core/serverless/README.md Co-authored-by: Scott Gerring <[email protected]> * Update examples/powertools-examples-core/serverless/README.md Co-authored-by: Scott Gerring <[email protected]> * Update examples/powertools-examples-core/serverless/README.md Co-authored-by: Scott Gerring <[email protected]> * Update examples/powertools-examples-core/serverless/README.md Co-authored-by: Scott Gerring <[email protected]> * Update examples/powertools-examples-core/serverless/README.md Co-authored-by: Scott Gerring <[email protected]> * Remove reduntant command from README * Move most of Powertools configuration to the service-wide environment * Remove more generated comments * Add newlines * Comment out annotations that are preceded by environment variables * Add link to the Serverless example * Update examples/powertools-examples-core/serverless/pom.xml Co-authored-by: Jérôme Van Der Linden <[email protected]> * Update examples/powertools-examples-core/serverless/pom.xml Co-authored-by: Jérôme Van Der Linden <[email protected]> * Update examples/powertools-examples-core/serverless/pom.xml Co-authored-by: Jérôme Van Der Linden <[email protected]> * Remove POWERTOOLS_LOGGER_LOG_EVENT, since it's unsupported --------- Co-authored-by: Scott Gerring <[email protected]> Co-authored-by: Jérôme Van Der Linden <[email protected]>
Issue #, if available:
#1067
Description of changes:
Adding Serverless Framework example
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.