Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix logging enum serialization #670

Merged

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Oct 22, 2024

Please provide the issue number

Issue number: #656

Summary

Changes

Serialize enum types correctly.
Add specific JsonConverter for LogLevel

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig October 22, 2024 08:31
@boring-cyborg boring-cyborg bot added area/logging Core logging utility tests labels Oct 22, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2024
@hjgraca hjgraca changed the title Fix(logging) enum serialization chore: Fix logging enum serialization Oct 22, 2024
@github-actions github-actions bot added the internal Maintenance changes label Oct 22, 2024
@hjgraca hjgraca mentioned this pull request Oct 22, 2024
1 task
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.48%. Comparing base (5eb8338) to head (c8684e8).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...ogging/Internal/Helpers/PowertoolsLoggerHelpers.cs 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #670      +/-   ##
===========================================
+ Coverage    73.43%   73.48%   +0.04%     
===========================================
  Files          196      197       +1     
  Lines         8027     8043      +16     
  Branches       857      860       +3     
===========================================
+ Hits          5895     5910      +15     
- Misses        1846     1847       +1     
  Partials       286      286              
Flag Coverage Δ
unittests 73.48% <90.47%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 22, 2024

@leandrodamascena leandrodamascena self-requested a review October 22, 2024 09:01
@hjgraca hjgraca merged commit 5b27080 into aws-powertools:develop Oct 22, 2024
8 checks passed
@hjgraca hjgraca deleted the fix(logging)-enum-serialization branch October 22, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Core logging utility internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants