chore: Change the way we reference Common and JMESPath (internal references).

[hjgraca]

Please provide the issue number

Issue number: #626

Summary

Changes

This change will stop the copy of common for each project and do that at build time only.
This setup simplifies the configuration, it treats Common and JMESPath as implementation details of the Idempotency package.

This approach should:

• Include Common and JMESPath for compilation in the Idempotency project
• Not copy the Common and JMESPath DLLs to the output directory of projects that reference Idempotency
• Ensure that when the Idempotency package is created, it includes the necessary parts of Common and JMESPath
• Work consistently across Debug and Release builds

Replace PrivateAssets=all and simplify Directory.Build.targets.
with

<Private>false</Private>
<ExcludeAssets>runtime</ExcludeAssets>

This comes after removing JMESPath from Directory.Build.targets #627 and an issue with idempotency #626

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

• Meets tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.45%. Comparing base (4029b08) to head (f9f313c).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #641      +/-   ##
===========================================
- Coverage    72.78%   72.45%   -0.33%     
===========================================
  Files          190      190              
  Lines         7886     7886              
  Branches       850      850              
===========================================
- Hits          5740     5714      -26     
- Misses        1857     1878      +21     
- Partials       289      294       +5     

Flag	Coverage Δ
unittests	72.45% <ø> (-0.33%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amirkaws]

LGTM