Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix docs missing closing tag #639

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Aug 28, 2024

Please provide the issue number

Issue number: #633

Summary

Changes

Fix missing closing tag after public references section

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Signed-off-by: Henrique Graca <[email protected]>
@auto-assign auto-assign bot requested review from amirkaws and sliedig August 28, 2024 13:57
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Aug 28, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 28, 2024
@github-actions github-actions bot added the internal Maintenance changes label Aug 28, 2024
Copy link

sonarcloud bot commented Aug 28, 2024

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.73%. Comparing base (04cbc46) to head (aefda53).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #639      +/-   ##
===========================================
- Coverage    72.78%   72.73%   -0.06%     
===========================================
  Files          190      190              
  Lines         7886     7886              
  Branches       850      850              
===========================================
- Hits          5740     5736       -4     
- Misses        1857     1860       +3     
- Partials       289      290       +1     
Flag Coverage Δ
unittests 72.73% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjgraca hjgraca merged commit 4029b08 into develop Aug 29, 2024
8 of 9 checks passed
@hjgraca hjgraca deleted the fix(docs)-missing-closing-tag branch August 29, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants