Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Pushpay as a public reference #633

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Aug 21, 2024

Please provide the issue number

Issue number: #631

Summary

Changes

Lance French, Engineering Manager, opened a #631 to add Pushpay as a public reference for Powertools for AWS Lambda.

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig August 21, 2024 15:17
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Aug 21, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2024
@github-actions github-actions bot added the internal Maintenance changes label Aug 21, 2024
Copy link

sonarcloud bot commented Aug 21, 2024

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (00d7c76) to head (a7da243).
Report is 14 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #633   +/-   ##
========================================
  Coverage    72.72%   72.72%           
========================================
  Files          190      190           
  Lines         7874     7874           
  Branches       850      850           
========================================
  Hits          5726     5726           
  Misses        1858     1858           
  Partials       290      290           
Flag Coverage Δ
unittests 72.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena merged commit e666521 into aws-powertools:develop Aug 22, 2024
9 checks passed
@hjgraca hjgraca deleted the publicref/pushpay branch August 22, 2024 11:35
@hjgraca hjgraca mentioned this pull request Aug 28, 2024
7 tasks
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal Maintenance changes pending-release Fix or implementation already in dev waiting to be released size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants