Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tracing add AOT support #607

Merged
merged 15 commits into from
Jul 24, 2024

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jul 4, 2024

Please provide the issue number

Issue number: #212

Summary

Tracing support for AOT

Changes

Remove dependency from UniversalWrapperAspect.cs and refactor Tracing attribute/decorator
.NET8 specific paths in code
Refactor TracingAttributeTest.cs no more mocks

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added area/tracing Core tracing utility tests labels Jul 4, 2024
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 4, 2024
@auto-assign auto-assign bot requested review from amirkaws and sliedig July 4, 2024 10:39
@github-actions github-actions bot added the internal Maintenance changes label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (eef0ea8) to head (5f2b82a).

Files Patch % Lines
...ambda.Powertools.Tracing/Internal/TracingAspect.cs 98.27% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #607      +/-   ##
===========================================
- Coverage    72.44%   72.41%   -0.03%     
===========================================
  Files          190      190              
  Lines         7897     7874      -23     
  Branches       852      850       -2     
===========================================
- Hits          5721     5702      -19     
+ Misses        1888     1878      -10     
- Partials       288      294       +6     
Flag Coverage Δ
unittests 72.41% <98.27%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jul 5, 2024
@hjgraca hjgraca added the aot label Jul 12, 2024
Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Jul 24, 2024

@hjgraca hjgraca merged commit aef100c into aws-powertools:develop Jul 24, 2024
6 of 7 checks passed
@hjgraca hjgraca deleted the aot-tracing-support branch July 24, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aot area/tracing Core tracing utility documentation Improvements or additions to documentation internal Maintenance changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants