Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update codecov #605

Merged
merged 6 commits into from
Jul 3, 2024
Merged

chore: Update codecov #605

merged 6 commits into from
Jul 3, 2024

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jul 3, 2024

Please provide the issue number

Issue number: #604

Summary

Changes

update codecov version

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Signed-off-by: Henrique Graca <[email protected]>
@auto-assign auto-assign bot requested a review from amirkaws July 3, 2024 09:32
@boring-cyborg boring-cyborg bot added the github-actions Changes in GitHub workflows label Jul 3, 2024
@auto-assign auto-assign bot requested a review from sliedig July 3, 2024 09:32
@boring-cyborg boring-cyborg bot added the internal Maintenance changes label Jul 3, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2024
hjgraca added 3 commits July 3, 2024 10:47
Signed-off-by: Henrique Graca <[email protected]>
Signed-off-by: Henrique Graca <[email protected]>
Signed-off-by: Henrique Graca <[email protected]>
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2024
Copy link

sonarcloud bot commented Jul 3, 2024

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.63%. Comparing base (a1a53c2) to head (8a45b80).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #605      +/-   ##
===========================================
+ Coverage    72.30%   72.63%   +0.32%     
===========================================
  Files          190      190              
  Lines         7905     7905              
  Branches       851      851              
===========================================
+ Hits          5716     5742      +26     
+ Misses        1893     1872      -21     
+ Partials       296      291       -5     
Flag Coverage Δ
unittests 72.63% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca hjgraca merged commit cb11aff into develop Jul 3, 2024
10 checks passed
@hjgraca hjgraca deleted the hjgraca-codecov branch July 3, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Changes in GitHub workflows internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants