chore: Metrics - Add support for AOT #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Refactor EMFValidationTests.cs no more mocks
boring-cyborg
bot
added
area/common
pull-request-size
bot
added
the
size/XXL
2 tasks
boring-cyborg
bot
added
the
documentation
amirkaws
reviewed
Jul 2, 2024
libraries/src/AWS.Lambda.Powertools.Metrics/MetricsAttribute.cs
Outdated
Show resolved
Hide resolved
hjgraca
changed the title
hjgraca
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #602 +/- ##
===========================================
+ Coverage 72.30% 72.55% +0.24%
===========================================
Files 190 190
Lines 7905 7900 -5
Branches 851 850 -1
===========================================
+ Hits 5716 5732 +16
+ Misses 1893 1877 -16
+ Partials 296 291 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #212
Summary
Metrics support for AOT
Changes
Add new MetricsSerializationContext.cs for AOT source generated serialization
Remove dependency from UniversalWrapperAspect.cs and refactor Metric attribute/decorator
.NET8 specific paths in code
Refactor EMFValidationTests.cs no more mocks
User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.