Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix jmespath dependency #590

Merged
merged 4 commits into from
May 9, 2024

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented May 9, 2024

Please provide the issue number

Issue number: #585

Summary

Issue when packaging the Idempotency Nuget package now that we target multiple frameworks due to the open issue on the Nuget repository NuGet/Home#3891

Changes

Manually adding the JMESPath dll to the output so it is available on the Idempotency Nuget package.

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig May 9, 2024 14:30
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 9, 2024
@hjgraca hjgraca changed the title bug: Fix jmespath dependency chore: Fix jmespath dependency May 9, 2024
@github-actions github-actions bot added bug Unexpected, reproducible and unintended software behaviour internal Maintenance changes labels May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.54%. Comparing base (7a10387) to head (16667a0).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #590      +/-   ##
===========================================
- Coverage    72.59%   72.54%   -0.06%     
===========================================
  Files          190      190              
  Lines         7901     7901              
  Branches       851      851              
===========================================
- Hits          5736     5732       -4     
- Misses        1874     1877       +3     
- Partials       291      292       +1     
Flag Coverage Δ
unittests 72.54% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca hjgraca merged commit 1d227a8 into aws-powertools:develop May 9, 2024
7 of 8 checks passed
@hjgraca hjgraca deleted the fix-jmespath-dep branch May 9, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/idempotency bug Unexpected, reproducible and unintended software behaviour internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants