Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo in metrics README #157

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

kenfdev
Copy link
Contributor

@kenfdev kenfdev commented Sep 21, 2022

Summary

Related issue: #162

Changes

Please provide a summary of what's being changed

Fixed a small typo in the Metrics example title for future readers.

User experience

Please share what the user experience looks like before and after this change

Only docs change.

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

No.

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered examples/Metrics/README.md

@amirkaws
Copy link
Contributor

amirkaws commented Oct 3, 2022

Hi @kenfdev, Thanks for the contribution. It's highly appreciated. Can I ask you please to kindly create an issue for that and associate this PR to the issue?

@amirkaws amirkaws added documentation Improvements or additions to documentation area/metrics Core metrics utility labels Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge PRs that are blocked for varying reasons need-issue PR is missing a related issue for tracking change labels Oct 3, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 56.29% // Head: 56.35% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (4cb45ea) compared to base (6a2e23a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #157      +/-   ##
===========================================
+ Coverage    56.29%   56.35%   +0.05%     
===========================================
  Files           41       41              
  Lines         1778     1778              
===========================================
+ Hits          1001     1002       +1     
+ Misses         777      776       -1     
Flag Coverage Δ
unittests 56.35% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...da.Powertools.Logging/Internal/PowertoolsLogger.cs 90.96% <0.00%> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kenfdev
Copy link
Contributor Author

kenfdev commented Oct 6, 2022

@amirkaws
Thanks for your attention! I've created the issue and pointed to it in the descriptions.

@sliedig sliedig removed the need-issue PR is missing a related issue for tracking change label Dec 22, 2022
@sliedig sliedig merged commit 810dd7f into aws-powertools:develop Dec 22, 2022
@github-actions
Copy link

@awslabs/aws-lambda-powertools-net No related issues found. Please ensure 'pending-release' label is applied before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Core metrics utility do-not-merge PRs that are blocked for varying reasons documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants