Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Fargate OSS pattern logs enabled | FluentBit #137

Merged
merged 12 commits into from
Feb 5, 2024

Conversation

Howlla
Copy link
Contributor

@Howlla Howlla commented Jan 3, 2024

Issue #, if available:

Description of changes: Remove hardcoded coreDNS version to "auto" and updated fargate cluster provider to kube 1.28

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Howlla Thanks for the PR. Have minor comments.

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me run e2e.

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-awsnative-fargate-observability deploy

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-fargate-opensource-observability deploy

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-awsnative-fargate-observability deploy

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-awsnative-fargate-observability destroy

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-fargate-opensource-observability deploy

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-fargate-opensource-observability destroy

@elamaran11
Copy link
Contributor

@Howlla Delete stack is failing with below error. Please fix this

single-new-eks-fargate-opensource-observability-accelerator |  53 | 5:35:41 PM | DELETE_FAILED        | AWS::CloudFormation::Stack            | single-new-eks-fargate-opensource-observability-accelerator The following resource(s) failed to delete: [singleneweksfargateopensourceobservabilityacceleratorCoreDnsComputeTypePatchDC03326B].

Failed resources:
single-new-eks-fargate-opensource-observability-accelerator | 5:33:28 PM | DELETE_FAILED        | Custom::AWSCDK-EKS-KubernetesPatch    | single-new-eks-fargate-opensource-observability-accelerator/CoreDnsComputeTypePatch/Resource/Default (singleneweksfargateopensourceobservabilityacceleratorCoreDnsComputeTypePatchDC03326B) Received response status [FAILED] from custom resource. Message returned: Error: b'Error from server (NotFound): deployments.apps "coredns" not found\n'

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Howlla Impressive work. I think the documentation is not update to date. This section is incorrect on logging, we need to update this to what you have done with some screenshots.

@Howlla
Copy link
Contributor Author

Howlla commented Feb 3, 2024

done @elamaran11.

@elamaran11
Copy link
Contributor

@Howlla Doc Markdown failures, pls fix those.

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Howlla Pls fix these

@Howlla Howlla changed the title PR - Fargate patterns version upgrade to Kube 1.28 PR - Fargate OSS pattern logs enabled | FluentBit Feb 4, 2024
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some convention issues.

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-fargate-opensource-observability deploy

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-fargate-opensource-observability destroy

@elamaran11
Copy link
Contributor

Expected Fargate Destroy Failure. Merging the PR.

@elamaran11 elamaran11 merged commit 32fdf78 into aws-observability:main Feb 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants