-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR - Fargate OSS pattern logs enabled | FluentBit #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Howlla Thanks for the PR. Have minor comments.
lib/single-new-eks-fargate-opensource-observability-pattern/index.ts
Outdated
Show resolved
Hide resolved
lib/single-new-eks-fargate-opensource-observability-pattern/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let me run e2e.
/do-e2e-test single-new-eks-awsnative-fargate-observability deploy |
/do-e2e-test single-new-eks-fargate-opensource-observability deploy |
/do-e2e-test single-new-eks-awsnative-fargate-observability deploy |
/do-e2e-test single-new-eks-awsnative-fargate-observability destroy |
/do-e2e-test single-new-eks-fargate-opensource-observability deploy |
/do-e2e-test single-new-eks-fargate-opensource-observability destroy |
@Howlla Delete stack is failing with below error. Please fix this
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done @elamaran11. |
@Howlla Doc Markdown failures, pls fix those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Howlla Pls fix these
lib/single-new-eks-fargate-opensource-observability-pattern/fluentbitconfig.yml
Outdated
Show resolved
Hide resolved
lib/single-new-eks-fargate-opensource-observability-pattern/fluentbitconfig.yml
Outdated
Show resolved
Hide resolved
lib/single-new-eks-fargate-opensource-observability-pattern/fluentbitconfigmap.ts
Show resolved
Hide resolved
lib/single-new-eks-fargate-opensource-observability-pattern/fluentbitconfig.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some convention issues.
lib/single-new-eks-fargate-opensource-observability-pattern/fluentbitconfigmap.ts
Outdated
Show resolved
Hide resolved
lib/single-new-eks-fargate-opensource-observability-pattern/fluentbitconfigmap.ts
Outdated
Show resolved
Hide resolved
lib/single-new-eks-fargate-opensource-observability-pattern/index.ts
Outdated
Show resolved
Hide resolved
/do-e2e-test single-new-eks-fargate-opensource-observability deploy |
/do-e2e-test single-new-eks-fargate-opensource-observability destroy |
Expected Fargate Destroy Failure. Merging the PR. |
Issue #, if available:
Description of changes: Remove hardcoded coreDNS version to "auto" and updated fargate cluster provider to kube 1.28
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.