OSS pattern for EKS Fargate new cluster #106

ratnopamc · 2023-08-30T12:24:58Z

Issue #, if available:
#51
Description of changes:
This PR contains the code for single new eks cluster on AWS Fargate.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

elamaran11

@ratnopamc Thanks for the draft PR. Docs is missing, mkdocs change is missing, and other feedback listed below. Also fix all lint errors

lib/single-new-eks-fargate-opensource-observability-pattern/index.ts

elamaran11 · 2023-09-13T20:00:43Z

@ratnopamc Any progress on this PR?

ratnopamc · 2023-10-22T05:59:38Z

@elamaran11, The PR is ready for review. Added the documentation with steps for testing with sample java workload.

elamaran11

@ratnopamc AWSome work, thankyou for working on this much needed pattern. Have some tactical comments and feedback which can be addressed, overall feedback

Doc needs a beefup about what is fargate, why we need this pattern, more details on AMP, AMG services uses and monitoring about Fargate. Use the Observability best practices guide for more info.
Architecture Diagram is must.
Since we are updating the collector config, please make sure you run OSS and Graviton/GPU pattern once and show evidence it works and you can see metrics in AMG.

elamaran11 · 2023-10-23T15:41:28Z

lib/single-new-eks-fargate-opensource-observability-pattern/grafanaoperatorsecretaddon.ts

@@ -0,0 +1,75 @@
+import 'source-map-support/register';


Could we remove this file and reuse the file from OSS pattern.

This is not taken care?

lib/common/resources/otel-collector-config.yml

elamaran11 · 2023-10-23T15:42:25Z

lib/single-new-eks-fargate-opensource-observability-pattern/index.ts

+    constructor(scope: Construct, id: string) {
+        const stackId = `${id}-observability-accelerator`;
+
+


remove extra space

This is not taken care.

lib/single-new-eks-fargate-opensource-observability-pattern/index.ts

elamaran11 · 2023-10-23T15:43:40Z

lib/single-new-eks-fargate-opensource-observability-pattern/index.ts

+                values: { webhook: { port: 9443 } }
+            }),
+            new blueprints.addons.GrafanaOperatorAddon({
+                version: 'v5.0.0-rc3'


remove this, we have upgrade GO to latest versionin blueprints

Not taken care?

lib/single-new-eks-fargate-opensource-observability-pattern/index.ts

elamaran11 · 2023-10-23T15:44:56Z

mkdocs.yml

@@ -42,6 +42,7 @@ nav:
      - OSS GPU: patterns/single-new-eks-observability-accelerators/single-new-eks-gpu-opensource-observability.md
      - OSS Java Mon : patterns/single-new-eks-observability-accelerators/single-new-eks-java-opensource-observability.md
      - OSS Nginx Mon : patterns/single-new-eks-observability-accelerators/single-new-eks-nginx-opensource-observability.md
+      - EKS Fargate OSS: patterns/single-new-eks-observability-accelerators/single-new-eks-fargate-opensource-observability.md 


lets create a Separate folder for EKS Fargate and under that add this. Also move AWS Native Fargate pattern too.

Not taken care

ratnopamc · 2023-10-24T21:35:06Z

/do-e2e-test

elamaran11

@Howlla @ratnopamc Great work, i see lot of improvement and i love the Architecture and documentation updates. Still following needs to be taken care

This PR is dependent on this PR in GitOps repo which has GitHub Action errors
The PR still has code comments which is not take care, please take care of those
The PR still has questions which needs responses

once you take care of all of these, we can move to e2e and merge.

elamaran11 · 2023-11-08T12:53:31Z

lib/single-new-eks-fargate-opensource-observability-pattern/grafanaoperatorsecretaddon.ts

@@ -0,0 +1,75 @@
+import 'source-map-support/register';


This is not taken care?

elamaran11 · 2023-11-08T12:54:25Z

lib/single-new-eks-fargate-opensource-observability-pattern/index.ts

+    constructor(scope: Construct, id: string) {
+        const stackId = `${id}-observability-accelerator`;
+
+


This is not taken care.

lib/single-new-eks-fargate-opensource-observability-pattern/index.ts

elamaran11 · 2023-11-08T12:55:03Z

lib/single-new-eks-fargate-opensource-observability-pattern/index.ts

+                values: { webhook: { port: 9443 } }
+            }),
+            new blueprints.addons.GrafanaOperatorAddon({
+                version: 'v5.0.0-rc3'


Not taken care?

elamaran11 · 2023-11-08T12:55:13Z

mkdocs.yml

@@ -42,6 +42,7 @@ nav:
      - OSS GPU: patterns/single-new-eks-observability-accelerators/single-new-eks-gpu-opensource-observability.md
      - OSS Java Mon : patterns/single-new-eks-observability-accelerators/single-new-eks-java-opensource-observability.md
      - OSS Nginx Mon : patterns/single-new-eks-observability-accelerators/single-new-eks-nginx-opensource-observability.md
+      - EKS Fargate OSS: patterns/single-new-eks-observability-accelerators/single-new-eks-fargate-opensource-observability.md 


Not taken care

elamaran11

@Howlla Looks great just one feedback. Remove the -new.yaml collector config file always from checkin or add it to gitignore. Running e2e but this needs to be fixed and also this PR to be fixed and merged before merge.

Also replace XRAYADOT to XRAY Addon in AWS Native Fargate pattern

lib/common/resources/otel-collector-config-new.yml

elamaran11 · 2023-11-10T01:58:09Z

/do-e2e-test single-new-eks-fargate-opensource-observability deploy

elamaran11 · 2023-11-10T02:03:09Z

/do-e2e-test single-new-eks-opensource-observability deploy

Howlla · 2023-11-10T06:42:18Z

updated gitignore

elamaran11 · 2023-11-10T13:21:55Z

@Howlla AWS Native Fargate pattern should be updated to replace XrayAdotAddOn with XrayAddOn thats a bug in the previous pattern. Im running e2e, but this needs to be fixed before merge.

elamaran11 · 2023-11-10T13:22:05Z

/do-e2e-test single-new-eks-fargate-opensource-observability deploy

elamaran11 · 2023-11-10T15:19:31Z

/do-e2e-test single-new-eks-fargate-opensource-observability destroy

elamaran11 · 2023-11-10T15:33:53Z

e2e error, no issues with the pattern, merging the pattern

ratnopamc added 3 commits August 29, 2023 20:11

add eks fargate opensource observability pattern

c5f96f4

Merge branch 'aws-observability:main' into main

3b58470

add eks fargate opensource observability pattern

4d60428

elamaran11 requested changes Aug 30, 2023

View reviewed changes

ratnopamc added 6 commits October 21, 2023 08:24

Merge remote-tracking branch 'upstream/main'

048e3cc

EKS fargate OSS pattern

744c8c4

EKS fargate OSS pattern

41c7d75

EKS fargate OSS pattern

2bd6b9d

EKS fargate OSS pattern

b80b400

EKS fargate OSS pattern

1449a4d

EKS fargate OSS pattern

128c790

elamaran11 requested changes Oct 23, 2023

View reviewed changes

elamaran11 linked an issue Oct 23, 2023 that may be closed by this pull request

Open Source EKS on Fargate Monitoring #51

Closed

updated docs and arch diagram

90bd062

elamaran11 requested changes Nov 8, 2023

View reviewed changes

Howlla added 2 commits November 8, 2023 10:08

add text in docs

1c58af6

comment fixes

ac750c8

elamaran11 reviewed Nov 10, 2023

View reviewed changes

lib/common/resources/otel-collector-config-new.yml Outdated Show resolved Hide resolved

update gitignore

e11ac7e

elamaran11 approved these changes Nov 10, 2023

View reviewed changes

elamaran11 merged commit e8afb45 into aws-observability:main Nov 10, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OSS pattern for EKS Fargate new cluster #106

OSS pattern for EKS Fargate new cluster #106

ratnopamc commented Aug 30, 2023

elamaran11 left a comment •

edited

Loading

elamaran11 commented Sep 13, 2023

ratnopamc commented Oct 22, 2023

elamaran11 left a comment

elamaran11 Oct 23, 2023

elamaran11 Nov 8, 2023

Howlla Nov 9, 2023

elamaran11 Oct 23, 2023

elamaran11 Nov 8, 2023

Howlla Nov 9, 2023

elamaran11 Oct 23, 2023

elamaran11 Nov 8, 2023

elamaran11 Oct 23, 2023

elamaran11 Nov 8, 2023

Howlla Nov 9, 2023

ratnopamc commented Oct 24, 2023

elamaran11 left a comment

elamaran11 Nov 8, 2023

elamaran11 Nov 8, 2023

elamaran11 Nov 8, 2023

elamaran11 Nov 8, 2023

elamaran11 left a comment •

edited

Loading

elamaran11 commented Nov 10, 2023

elamaran11 commented Nov 10, 2023

Howlla commented Nov 10, 2023

elamaran11 commented Nov 10, 2023

elamaran11 commented Nov 10, 2023

elamaran11 commented Nov 10, 2023

elamaran11 commented Nov 10, 2023

		constructor(scope: Construct, id: string) {
		const stackId = `${id}-observability-accelerator`;

OSS pattern for EKS Fargate new cluster #106

OSS pattern for EKS Fargate new cluster #106

Conversation

ratnopamc commented Aug 30, 2023

elamaran11 left a comment • edited Loading

Choose a reason for hiding this comment

elamaran11 commented Sep 13, 2023

ratnopamc commented Oct 22, 2023

elamaran11 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ratnopamc commented Oct 24, 2023

elamaran11 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elamaran11 left a comment • edited Loading

Choose a reason for hiding this comment

elamaran11 commented Nov 10, 2023

elamaran11 commented Nov 10, 2023

Howlla commented Nov 10, 2023

elamaran11 commented Nov 10, 2023

elamaran11 commented Nov 10, 2023

elamaran11 commented Nov 10, 2023

elamaran11 commented Nov 10, 2023

elamaran11 left a comment •

edited

Loading

elamaran11 left a comment •

edited

Loading