Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing HELM values file overrwrite some settings from addon #1609

Closed
mk2134226 opened this issue May 19, 2023 · 1 comment
Closed

Passing HELM values file overrwrite some settings from addon #1609

mk2134226 opened this issue May 19, 2023 · 1 comment

Comments

@mk2134226
Copy link

I was passing helm values for karpeneter addons via file and that override your settings fromt his file

https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/modules/kubernetes-addons/karpenter/locals.tf#L25

You should merge the values rather than override like settings variable if i pass settings var with single field then it override it and remove critical components clike clusterName etc

image
@bryantbiggs
Copy link
Contributor

we will be tracking future changes to the GitOps integration here aws-ia/terraform-aws-eks-blueprints-addons#114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants