-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades for karpenter v0.19.1 #1175
Comments
Perhaps we also need to maintain backward compatibility so that karpenter < v0.19.0 can also be installed. |
what do you propose @armujahid ? |
@FernandoMiguel we can somehow add a conditional check while setting helm values (and IAM policies?) similar to So that new logic will only run for karpenter >= 0.19.0 and flow remain unchanged for older versions |
@armujahid but we dont have go here... only terraform |
we can keep HEAD using latest karpenter, and anyone that needs the older config can use a previous release tag |
@FernandoMiguel yeah that's logical. we can document this somewhere and/or restrict user to select karpenter version less than 0.19.0 |
@armujahid i wouldnt know how that is best handled on this project since I dont handle release notes |
users are able to provide both the version of Karpenter as well as its associated values so we don't need to worry about anything dynamic |
Things that need upgrade:
karpenter-global-settings
The text was updated successfully, but these errors were encountered: