Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades for karpenter v0.19.1 #1175

Closed
askulkarni2 opened this issue Nov 15, 2022 · 8 comments · Fixed by #1145
Closed

Upgrades for karpenter v0.19.1 #1175

askulkarni2 opened this issue Nov 15, 2022 · 8 comments · Fixed by #1145
Labels
enhancement New feature or request

Comments

@askulkarni2
Copy link
Contributor

askulkarni2 commented Nov 15, 2022

Things that need upgrade:

  1. Helm chart version upgrade
  2. Native Spot Termination Handling IRSA policy update (#2546)
  3. Update values.yaml for karpenter-global-settings
@armujahid
Copy link
Contributor

armujahid commented Nov 16, 2022

Perhaps we also need to maintain backward compatibility so that karpenter < v0.19.0 can also be installed.

@FernandoMiguel
Copy link
Contributor

Perhaps we also need to maintain backward compatibility so that karpenter < v0.19 can also be installed.

what do you propose @armujahid ?

@armujahid
Copy link
Contributor

armujahid commented Nov 16, 2022

@FernandoMiguel we can somehow add a conditional check while setting helm values (and IAM policies?) similar to
https://github.com/weaveworks/eksctl/pull/5934/files#diff-4dcf687b868f9aa422944c40d074a7948519882a86e66375305ee74963b821a7R87

So that new logic will only run for karpenter >= 0.19.0 and flow remain unchanged for older versions

@FernandoMiguel
Copy link
Contributor

@armujahid but we dont have go here... only terraform
not sure how the maintainers of this project would want to handle this

@FernandoMiguel
Copy link
Contributor

we can keep HEAD using latest karpenter, and anyone that needs the older config can use a previous release tag

@armujahid
Copy link
Contributor

armujahid commented Nov 16, 2022

@FernandoMiguel yeah that's logical. we can document this somewhere and/or restrict user to select karpenter version less than 0.19.0

@FernandoMiguel
Copy link
Contributor

@armujahid i wouldnt know how that is best handled on this project since I dont handle release notes

@bryantbiggs bryantbiggs changed the title Upgrades for karpenter v0.19.0 Upgrades for karpenter v0.19.1 Nov 19, 2022
@bryantbiggs
Copy link
Contributor

users are able to provide both the version of Karpenter as well as its associated values so we don't need to worry about anything dynamic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants