-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example - Karpenter on Fargate #1159
Comments
the current example for Karpenter is already configured for running on Fargate. If there are additional features/questions related to this pattern, please feel free to open a new issue describing the solution you would like to see or have answered Ref: https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples/karpenter |
I'm not sure why you are closing this issue since https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples/karpenter does not provide the following items:
Why are you asking me to open a new issue when this one already contains the proposed solution? |
Because I don't think a separate example is warranted just for those items, no?
What are we trying to demonstrate with this, what should users take away from the example? Is this just showing what you can do this with Karpenter, or is there something specific we are trying to highlight. Lastly - why are these important enough to highlight to users
What makes this unique from a Karpenter perspective since these are Kubernetes constructs? What should users take away from demonstrating these?
I'm not following this one. We have an example that shows a fully serverless cluster running on Fargate profiles with a sample app and AWS LBC. If we want to add those addons here just to show resources running on compute provided by Karpenter, I think thats fine to add |
I think it would have been better to clarify these points before working on the PR. The description of this issue is the same since Nov 10, 2022. I was assigned to it and no questions where asked at that time so I assumed it was OK. I also tried to answer all the questions (similar to the ones you are asking here) that were asked in #1187 but did not get any feedback that could have help improving the PR. |
Community Note
What is the outcome that you are trying to reach?
Reference documentation:
Describe the solution you would like
nodeSelector
,topologySpreadConstraints
, andpodAntiAffinity
Describe alternatives you have considered
Additional context
I have tested this approach already and I have code that could be used to create this example.
The text was updated successfully, but these errors were encountered: