Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Management to support different personas and features #18

Closed
haofeif opened this issue Aug 2, 2023 · 13 comments
Closed

Team Management to support different personas and features #18

haofeif opened this issue Aug 2, 2023 · 13 comments
Labels

Comments

@haofeif
Copy link

haofeif commented Aug 2, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?

The current team management module does not provide flexibility for the team to provide customized feature to create different RBAC roles/IAM roles for different personas, it is not very easy to be used.

We would like to provide flexibility for the team management to provide additional IAM Roles/RBAC roles, cross-account assume roles, network policies bootstrapped for each namespace.

Describe the solution you would like

We would like the solution to cater for users inputting parameters to enable additional personas and features mentioned above

Describe alternatives you have considered

N/A

Additional context

@bryantbiggs
Copy link
Contributor

are you referring to gaps in the current implementation at https://github.com/aws-ia/terraform-aws-eks-blueprints-teams?

@bryantbiggs bryantbiggs transferred this issue from aws-ia/terraform-aws-eks-blueprints Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Sep 2, 2023
@haofeif
Copy link
Author

haofeif commented Sep 4, 2023

are you referring to gaps in the current implementation at https://github.com/aws-ia/terraform-aws-eks-blueprints-teams?

@bryantbiggs yes it is.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 5, 2023
@haofeif
Copy link
Author

haofeif commented Oct 5, 2023

@bryantbiggs do you have any updates on this ?

@github-actions github-actions bot removed the stale label Oct 6, 2023
@haofeif
Copy link
Author

haofeif commented Oct 24, 2023

@bryantbiggs @askulkarni2 fyi... Please let us know whether you need any other info.

@bryantbiggs
Copy link
Contributor

hey @haofeif - do you have more info on patterns or configurations that the module currently doesn't support? Perhaps if we can see some examples of whats trying to be created, we can work backwards to figure out what can or cannot be supported, or perhaps there are alternate routes to reach those outcomes.

@haofeif
Copy link
Author

haofeif commented Oct 26, 2023

Yes @bryantbiggs. For instance, in the current team management repo, if users would like to add customization ( i.e. providing flexibility like provide additional personas for IAM Roles/RBAC roles other than just the read-only and namespace admin roles, it is not supported.

Other features that are currently not supported including customization like cross-account assume roles (as usually the multi-tenancy cluster is hosted in a central AWS account, while tenants are accessing via their own accounts where they host their own RDS, S3 and other AWS resources) , network policies bootstrapped for each namespace . it is not possible in the current module as they are all hard coded.

For instance, below is the tenant/team definition

{
    "tenant1": {
      "aws_account_ids": [
        "509164722760"
      ],
      "compute_quota": {
        "requests.cpu": "1000m",
        "requests.memory": "12Gi",
        "limits.cpu": "2000m",
        "limits.memory": "12Gi"
      },
      "labels": {
        "bsbcc": "example",
        "appname": "example",
        "testingNewLabel": "blah"
      },
      "object_quota": { 
        "pods": "10",
        "secrets": "10",
        "services": "10"
      }
    },
    "tenant2": {
      "aws_account_ids": [
        "509164722760"
      ],
      "compute_quota": {
        "requests.cpu": "1000m",
        "requests.memory": "12Gi",
        "limits.cpu": "2000m",
        "limits.memory": "12Gi"
      },
      "labels": {
        "bsbcc": "example",
        "appname": "example",
        "testingNewLabel": "blah2"
      },
      "object_quota": { 
        "pods": "10",
        "secrets": "10",
        "services": "10"
      }
    }
  }

Which has the account info added in as the cross-account access.

Our team has developed our code which we are happy to contribute as a PR (we showed it to @askulkarni2 a couple months ago hence creating this issue post our conversations)

@bryantbiggs
Copy link
Contributor

if you have any code that is publicly available, we'd be happy to take a look to better understand the ask

Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 26, 2023
Copy link

github-actions bot commented Dec 7, 2023

Issue closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
@rodrigobersa rodrigobersa reopened this Dec 7, 2023
@github-actions github-actions bot removed the stale label Dec 8, 2023
Copy link

github-actions bot commented Jan 7, 2024

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 7, 2024
Copy link

Issue closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants