Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: elastic admin team creation without relying on system:master #17

Closed
LeoSpyke opened this issue Jun 20, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request teams

Comments

@LeoSpyke
Copy link
Contributor

LeoSpyke commented Jun 20, 2023

As of today, the creation of a new admin team (enable_admin=true) eventually produces an aws_auth_configmap_role output, which contains the hardcoded group system:masters.
Creating additional administrative users belonging to the above-mentioned group (other than the IAM Principal used to initially bootstrap the cluster, which is neither visible nor editable) is against best practices and discouraged for security purposes; it is like using the root account in your AWS environment.

Maybe an improvement can be implemented by giving the ability to choose whether the new team should be added to the system:master or to another one created ad hoc, like with the "Development Teams", thus creating a ClusterRoleBinding to the built-in cluster-admin ClusterRole. This will have the same effect as using system:masters, but would allow those rights to be removed if necessary, by removing the group from the ClusterRoleBinding.

@askulkarni2
Copy link
Contributor

I think this is a reasonable request. I will add it to our backlog.

@askulkarni2 askulkarni2 added the enhancement New feature or request label Jun 28, 2023
@rodrigobersa rodrigobersa self-assigned this Aug 16, 2023
@rodrigobersa
Copy link
Contributor

Hi @LeoSpyke!

If I understand correctly, you want a way to provide another existing Role or ClusterRole to the admin-team other than the system:masters, or replace the existing for another ClusterRoleBinding attached to the cluster-admin role. Is that correct?

@Daemoen
Copy link

Daemoen commented Jul 29, 2024

I'm assuming this project is now abandoned? There hasn't been any progress or work on it in a year.

@LeoSpyke
Copy link
Contributor Author

LeoSpyke commented Aug 5, 2024

I'm going to close this issue due to migration to EKS API and lack of interest.

@LeoSpyke LeoSpyke closed this as completed Aug 5, 2024
@bryantbiggs bryantbiggs moved this to Done in EKS Blueprints Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request teams
Projects
Status: Done
4 participants