-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using enable_aws_for_fluentbit = true creates a log group with a suffix but is used without it from the container #341
Comments
Based on these lines of code, if you don't specify the Then when setting up the values for the fluentbit helm chart here the code sets the I'm now trying to create a new cluster with this and in the terraform plan I can see that the value of the property is set to # module.prod_eu_north_1_cluster.module.eks_kubernetes_addons.module.aws_for_fluentbit.helm_release.this[0] will be created
+ resource "helm_release" "this" {
+ atomic = false
+ chart = "aws-for-fluent-bit"
+ cleanup_on_fail = false
+ create_namespace = false
+ dependency_update = false
+ description = "A Helm chart to install the Fluent-bit Driver"
+ disable_crd_hooks = false
+ disable_openapi_validation = false
+ disable_webhooks = false
+ force_update = false
+ id = (known after apply)
+ lint = false
+ manifest = (known after apply)
+ max_history = 0
+ metadata = (known after apply)
+ name = "aws-for-fluent-bit"
+ namespace = "kube-system"
+ pass_credentials = false
+ recreate_pods = false
+ render_subchart_notes = true
+ replace = false
+ repository = "https://aws.github.io/eks-charts"
+ reset_values = false
+ reuse_values = false
+ skip_crds = false
+ status = "deployed"
+ timeout = 300
+ values = []
+ verify = false
+ version = "0.1.32"
+ wait = false
+ wait_for_jobs = false
+ set {
+ name = "cloudWatch.region"
+ value = "eu-north-1"
# (1 unchanged attribute hidden)
}
+ set {
+ name = "cloudWatchLogs.autoCreateGroup"
+ value = "false"
# (1 unchanged attribute hidden)
}
# it's not using the prefix here
+ set {
+ name = "cloudWatchLogs.logGroupName"
+ value = "/aws/eks/prod-eu-north-1/aws-fluentbit-logs"
# (1 unchanged attribute hidden)
}
+ set {
+ name = "cloudWatchLogs.logGroupTemplate"
# (2 unchanged attributes hidden)
}
+ set {
+ name = "cloudWatchLogs.region"
+ value = "eu-north-1"
# (1 unchanged attribute hidden)
}
+ set {
+ name = "serviceAccount.annotations.eks\\.amazonaws\\.com/role-arn"
+ value = (known after apply)
# (1 unchanged attribute hidden)
}
+ set {
+ name = "serviceAccount.name"
+ value = "aws-for-fluent-bit-sa"
# (1 unchanged attribute hidden)
}
} The created log group has a # module.prod_eu_north_1_cluster.module.eks_kubernetes_addons.aws_cloudwatch_log_group.aws_for_fluentbit[0] will be created
+ resource "aws_cloudwatch_log_group" "aws_for_fluentbit" {
+ arn = (known after apply)
+ id = (known after apply)
+ log_group_class = (known after apply)
+ name = (known after apply)
+ name_prefix = "/aws/eks/prod-eu-north-1/aws-fluentbit-logs-"
+ retention_in_days = 90
+ skip_destroy = false
+ tags_all = (known after apply)
} Made a quick and dirty PR for this, haven't looked into it more (or tested it either). |
Description
Adding
enable_aws_for_fluentbit = true
to the configuration does create a log group,/aws/eks/jf-test-cluster/aws-fluentbit-logs-20240110180918467200000001
in my case, but no logs makes it there.This is not in line with the documentation [1] which states: "Check the list of log groups in the Region. You should see the following:
/aws/eks/complete/aws-fluentbit-logs
".Then, looking at the fluenbit container log I see
It looks like there is a disconnect between what is created (i.e. with the suffix) and what is referenced in the configmap (without the suffix)
I don't have any other fluentbit related config, but even specifying a different prefix in
aws_for_fluentbit_cw_log_group
doesn't help.[1] https://aws-ia.github.io/terraform-aws-eks-blueprints-addons/main/addons/aws-for-fluentbit/
The text was updated successfully, but these errors were encountered: