-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudFormation Resource Specification 20.3.0 #1781
CloudFormation Resource Specification 20.3.0 #1781
Conversation
1bf71bd
to
8dbb3c4
Compare
another instance of awslabs/goformation#300 "AWS::DataBrew::Recipe.Action": {
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-databrew-recipe-action.html",
"Properties": {
"Operation": {
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-databrew-recipe-action.html#cfn-databrew-recipe-action-operation",
"UpdateType": "Mutable",
"Required": true,
"PrimitiveType": "String"
},
"Parameters": {
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-databrew-recipe-action.html#cfn-databrew-recipe-action-parameters",
"UpdateType": "Mutable",
"Required": false
}
}
}, https://schema.cloudformation.us-east-1.amazonaws.com/aws-databrew-recipe.json |
'US West (Verizon) - San Francisco Bay Area': 'us-west-2', | ||
'US East (Verizon) - Miami': 'us-east-1', | ||
'US East (Verizon) - Dallas': 'us-east-1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if it'd be worth supporting patterns if this list keeps growing
https://aws.amazon.com/about-aws/whats-new/2020/11/announcing-new-aws-wavelength-zones-in-dallas-and-miami/
'US West (Verizon) - San Francisco Bay Area': 'us-west-2', | |
'US East (Verizon) - Miami': 'us-east-1', | |
'US East (Verizon) - Dallas': 'us-east-1', | |
'US West (Verizon) - .*': 'us-west-2', | |
'US East (Verizon) - .*': 'us-east-1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was starting to debate that too. I wonder if we can just drop the verizon data? I don't think it adds anything either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8dbb3c4
to
7f99f5c
Compare
# Auto generated files for testing | ||
test/fixtures/templates/bad/limit_numbers.yaml | ||
test/fixtures/templates/bad/limit_size.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch 👍 should've added this in #1747 but too accustomed to testing remotely with Travis
7f99f5c
to
c4f9832
Compare
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.