Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule W1051 to validate if dyn ref when arn #3962

Merged

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Feb 14, 2025

Issue #, if available:

Description of changes:

  • Add rule W1051 to validate if dynamic reference when arn

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong force-pushed the fix/internal/secretmanagerarn branch from bdd60f4 to 8e28374 Compare February 14, 2025 18:07
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.85%. Comparing base (1a259af) to head (cf88a4d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3962   +/-   ##
=======================================
  Coverage   93.84%   93.85%           
=======================================
  Files         372      373    +1     
  Lines       12779    12803   +24     
  Branches     2629     2636    +7     
=======================================
+ Hits        11993    12016   +23     
  Misses        436      436           
- Partials      350      351    +1     
Flag Coverage Δ
unittests 93.81% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the fix/internal/secretmanagerarn branch from 8e28374 to 7152776 Compare February 14, 2025 18:20
@kddejong kddejong merged commit b4d790d into aws-cloudformation:main Feb 24, 2025
24 checks passed
@kddejong kddejong deleted the fix/internal/secretmanagerarn branch February 24, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant