Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back better findinmap resolution #3579

Merged

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Aug 8, 2024

Issue #, if available:
fix #3531

Description of changes:

  • Bring back better findinmap resolution. Only provide resolution errors if all options fail.
  • Fix an issue with Mappings with integer keys

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong force-pushed the feature/resolvers/findinmap branch from 1cbb5c5 to 6f7a3bb Compare August 8, 2024 21:55
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.77%. Comparing base (240e525) to head (52943b3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cfnlint/context/_mappings.py 66.66% 0 Missing and 1 partial ⚠️
src/cfnlint/rules/functions/_BaseFn.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3579      +/-   ##
==========================================
- Coverage   93.77%   93.77%   -0.01%     
==========================================
  Files         356      356              
  Lines       12086    12111      +25     
  Branches     2587     2598      +11     
==========================================
+ Hits        11334    11357      +23     
  Misses        411      411              
- Partials      341      343       +2     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the feature/resolvers/findinmap branch 2 times, most recently from 362b5f7 to 5a0e007 Compare August 9, 2024 18:36
@kddejong kddejong force-pushed the feature/resolvers/findinmap branch from 58fbd58 to d791281 Compare August 19, 2024 17:56
@kddejong kddejong merged commit eba6a45 into aws-cloudformation:main Sep 3, 2024
20 checks passed
@kddejong kddejong deleted the feature/resolvers/findinmap branch September 3, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Validate Principal in S3 Bucket Policy is "*" or Map with Key as AWS
1 participant