Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to skip endpoint url prefix #49

Open
tfwright opened this issue Sep 17, 2020 · 1 comment
Open

Add ability to skip endpoint url prefix #49

tfwright opened this issue Sep 17, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@tfwright
Copy link

In the URL building logic for (I presume) all services, a prefix is currently being prepended to the endpoint host. I am using Digital Ocean and their Spaces API aims for AWS S3 parity, so I was hoping to use this lib to interface with it. However, their service does not use a prefix like s3 for obvious reasons. Since that is currently being hard coded into the url, I was getting a very cryptic error. I was able to work around the issue by adding an option to the client that instructs the service to skip the prefix in the host: tfwright/aws-elixir@72b45d2

If this is something you'd be open to adding, I can open a PR on this repo. There may be other solutions, like just requiring the user to specify the full url as the endpoint rather than composing it out of options, which might be a simpler and more flexible route to go.

@jfacorro
Copy link
Member

The url is being built automatically since this the approach other AWS clients take, it reduces the amount of work for the users of the library. I think an option to explicitly set the endpoint will be welcome by other users as long as it also supports the implicit case.

@jfacorro jfacorro added the enhancement New feature or request label Sep 28, 2020
@onno-vos-dev onno-vos-dev self-assigned this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants