Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart uploads which a recovered after app restart do not complete #3817

Closed
brennanMKE opened this issue Oct 13, 2021 · 1 comment
Closed
Labels
bug Something isn't working s3 Issues related to S3

Comments

@brennanMKE
Copy link
Contributor

Describe the bug

Multipart uploads stop before completing after the restart and recovery process.

To Reproduce
Steps to reproduce the behavior:

  1. Launch the app
  2. Start a fairly large multipart upload
  3. Kill the app just as parts are uploading
  4. Restart the app
  5. Observe that parts stop uploading and the process does not complete

Observed Behavior

For my dev app the MU process after a restart the progress bar would stop at 50% and stall there.

Expected Behavior

The process should complete with each upload part completing followed by the MU complete request.

** Root Cause **

When the recovery process hydrate the multipart upload task the inProgressDictionary is populated with tasks which are suspended. It puts the number of in progress tasks over the limit and it prevents the process from resuming these sub tasks because they are not in the waiting dictionary.

@brennanMKE brennanMKE added bug Something isn't working pending-release Code has been merged but pending release s3 Issues related to S3 and removed pending-release Code has been merged but pending release labels Oct 16, 2021
@brennanMKE
Copy link
Contributor Author

Released: v2.26.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working s3 Issues related to S3
Projects
None yet
Development

No branches or pull requests

1 participant