fix(@aws-amplify/datastore): improve IDB query performance

[iartemiev]

This PR fixes a bug where calling DataStore.query(Post) without a pagination object would use the cursor-based fetch from IndexedDB, as opposed to getAll(), which is optimized specifically for getting all the records. This was having a negative effect on the performance of DataStore.query when retrieving all the items for a given model.

The pagination object was getting initialized to {limit: undefined, page: undefined, sort: undefined} in the DataStore.processPagination private method, therefore pagination always had a truthy value in the conditional checks that determine which retrieval method to utilize. This gets fixed here.

Also:

• Refactored IndexedDBAdapater.query to make it easier to test
• Added test coverage for IndexedDBAdapter, which ensures the correct retrieval method is used for all of the different combinations of parameters passed to IndexedDBAdapter.query

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

Merging #7746 (e5df7b2) into main (aecdf3c) will increase coverage by 0.05%.
The diff coverage is 98.70%.

@@            Coverage Diff             @@
##             main    #7746      +/-   ##
==========================================
+ Coverage   74.07%   74.13%   +0.05%     
==========================================
  Files         214      215       +1     
  Lines       13410    13450      +40     
  Branches     2628     2641      +13     
==========================================
+ Hits         9934     9971      +37     
- Misses       3277     3280       +3     
  Partials      199      199              

Impacted Files	Coverage Δ
.../datastore/src/storage/adapter/IndexedDBAdapter.ts	78.40% <97.50%> (+0.66%)	⬆️
packages/datastore/src/datastore/datastore.ts	78.42% <100.00%> (+0.34%)	⬆️
...tastore/src/storage/adapter/AsyncStorageAdapter.ts	78.04% <100.00%> (+0.83%)	⬆️
...ges/datastore/src/storage/adapter/InMemoryStore.ts	72.72% <0.00%> (ø)
packages/datastore/src/util.ts	80.40% <0.00%> (+0.50%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aecdf3c...e5df7b2. Read the comment docs.

[amhinson]

Everything looks good to me. The refactor is much easier to follow. Although what do you think about doing the same thing for AsyncStorageAdapter for consistency's sake?

[manueliglesias]

It looks great!

I left 2 comments but they are non-blocking, let me know your thoughts

[iartemiev]

Everything looks good to me. The refactor is much easier to follow. Although what do you think about doing the same thing for AsyncStorageAdapter for consistency's sake?

@amhinson Agreed! I've refactored AsyncStorageAdapater.query to follow the same pattern and have added unit tests

[iartemiev]

@amhinson @manueliglesias - thanks for the thorough reviews and good suggestions, guys. I've updated the PR

[amhinson]

LGTM 👍

[github-actions]

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.