Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Logging Improvements #8354

Closed
eddiekeller opened this issue May 28, 2021 · 6 comments
Closed

RFC: Logging Improvements #8354

eddiekeller opened this issue May 28, 2021 · 6 comments
Labels
feature-request Request a new feature needs-discussion Used for internal discussions

Comments

@eddiekeller
Copy link
Contributor

eddiekeller commented May 28, 2021

Using this ticket as a storage site for ideas for future improvements for our logging solution.

** Future ideas **

  • CloudWatch EMF logging support
  • Support for more external cloud logging providers
  • Move Logging into its own api category?
  • Add in a separate log level for remote logging?
  • Store logs "offline" until connectivity is restored

Describe the solution you'd like

Will discuss with team moving forward about what ideas should take priority and outline a plan internally to tackle these. Will then create individual issues for each one.

@eddiekeller eddiekeller added feature-request Request a new feature needs-discussion Used for internal discussions labels May 28, 2021
@nubpro
Copy link
Contributor

nubpro commented May 30, 2021

Does CloudWatch logging works while offline?

@eddiekeller
Copy link
Contributor Author

@nubpro No, not yet. Although...I suppose the current implementation will keep trying to submit logs to CloudWatch while they exist in the queue...so once connectivity is restored, I would expect them to get pushed up.

But, that is an inelegant solution at the moment. There is certainly a better approach that can be taken. I will add that to the list in the parent comment.

@iCodeForBananas
Copy link

All of our teams lean into CloudWatch EMF logging quite heavily so that we don't have to setup MetricFilters in CDK. That will likely be a blocker for teams from migrating to this at the moment.

Store logs "offline" until connectivity is restored, I hadn't thought of this one but would be incredibly insightful.

@sammartinez
Copy link
Contributor

Resolving as this feature is out.

@aaronlna
Copy link
Contributor

aaronlna commented Nov 8, 2021

Thanks for releasing this feature.

I was trying to track down if there may be any future support for writing EMF logs or support for writing custom formatted logs, e.g. JSON log format for better querying with CW Insights. Are these improvements still being tracked anywhere or is support for these features at all planned?

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request a new feature needs-discussion Used for internal discussions
Projects
None yet
Development

No branches or pull requests

5 participants