Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN] Get guest credentials identity cached into AsyncStorage #835

Merged
merged 6 commits into from
May 15, 2018

Conversation

powerful23
Copy link
Contributor

@powerful23 powerful23 commented May 14, 2018

Issue #, if available:
When reloading the app, the guest user will get a new identity id because the previous one is not cached. Fixes #383
Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@powerful23 powerful23 requested a review from mlabieniec May 14, 2018 23:47
@powerful23 powerful23 requested a review from richardzcode as a code owner May 14, 2018 23:47
@powerful23 powerful23 requested a review from manueliglesias May 14, 2018 23:47
Copy link
Contributor

@mlabieniec mlabieniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented May 14, 2018

Codecov Report

Merging #835 into master will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #835      +/-   ##
=========================================
- Coverage   87.72%   87.7%   -0.02%     
=========================================
  Files          75      75              
  Lines        3593    3604      +11     
  Branches      683     684       +1     
=========================================
+ Hits         3152    3161       +9     
- Misses        419     420       +1     
- Partials       22      23       +1
Impacted Files Coverage Δ
...kages/aws-amplify/src/Common/RNComponents/index.ts 80% <100%> (+5%) ⬆️
packages/aws-amplify/src/Auth/Auth.ts 88.17% <83.33%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd9fcf...b1edfa8. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants