Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ServiceWorker utility class #831

Merged

Conversation

manueliglesias
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@manueliglesias manueliglesias force-pushed the feature/serviceworker branch from 8caaf5c to 8b7540f Compare May 15, 2018 19:38
@codecov-io
Copy link

codecov-io commented May 15, 2018

Codecov Report

Merging #831 into master will increase coverage by 0.04%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage    87.7%   87.75%   +0.04%     
==========================================
  Files          75       77       +2     
  Lines        3604     3666      +62     
  Branches      684      693       +9     
==========================================
+ Hits         3161     3217      +56     
- Misses        420      426       +6     
  Partials       23       23
Impacted Files Coverage Δ
packages/aws-amplify/src/Common/Amplify.ts 100% <100%> (ø) ⬆️
packages/aws-amplify/src/Common/index.ts 83.33% <100%> (+0.72%) ⬆️
...ages/aws-amplify/src/Common/ServiceWorker/index.ts 100% <100%> (ø)
...-amplify/src/Common/ServiceWorker/ServiceWorker.ts 89.83% <89.83%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead6ccd...346cbd7. Read the comment docs.

Copy link
Contributor

@powerful23 powerful23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants