Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

federated sign in for react native #818

Merged
merged 7 commits into from
May 15, 2018

Conversation

powerful23
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@powerful23 powerful23 requested a review from mlabieniec May 10, 2018 17:56
@powerful23 powerful23 requested a review from richardzcode as a code owner May 10, 2018 17:56
@codecov-io
Copy link

codecov-io commented May 10, 2018

Codecov Report

Merging #818 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #818      +/-   ##
==========================================
- Coverage   87.75%   87.72%   -0.03%     
==========================================
  Files          77       77              
  Lines        3666     3667       +1     
  Branches      693      693              
==========================================
  Hits         3217     3217              
- Misses        426      427       +1     
  Partials       23       23
Impacted Files Coverage Δ
packages/aws-amplify/src/Auth/Auth.ts 88.03% <66.66%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd46e3...1f89e08. Read the comment docs.

@sky1234
Copy link

sky1234 commented May 10, 2018

What is this fixing/enhancing? is it adding the federated signin feature for React Native. Please clarify.

@powerful23
Copy link
Contributor Author

@sky1234 This pr will allow developers to use Auth.federatedSignIn() in React Native to get a federated identity from third providers. Also fixes some issue of the Authenticator so now you will be logged in once you sign in with third provider

@sky1234
Copy link

sky1234 commented May 11, 2018

Thats great. if you can update documentation on "Authentication" section, that would be ideal. it specifically states Federated identity is not supported at multiple places. Please update, along with code fix.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants