fix(@aws-amplify/datastore): handle sync query unauthorized #7926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2021
Merged
Closed
This was referenced Mar 15, 2021
dgonsan
pushed a commit
to dgonsan/amplify-js
that referenced
this pull request
Mar 18, 2021
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the sync engine breaks when a sync query returns an
unauthorizederror.The expected behavior for DataStore is that an unauthorized error on a model should not break syncing for other models.
Currently, when a sync query request returns unauthorized, we get the following unhandled error
on this line.
An unauthorized query response typically won't return any
items, so this PR adds a check to see ifitemsare defined before attempting to iterate over them. If not defined, we return an empty list (items: []) andnextToken: nullto signal to theretrievePagemethod that it shouldn't attempt to retrieve additional pages via this query.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.