fix(aws-amplify-react-native): respect user provided theme in react-native withAuthenticator HOC #7925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7925 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 215 215
Lines 13470 13470
Branches 2645 2645
=======================================
Hits 10004 10004
Misses 3268 3268
Partials 198 198 Continue to review full report at Codecov.
|
amhinson
approved these changes
Mar 11, 2021
amhinson
changed the title
Ashish-Nanda
approved these changes
Mar 11, 2021
This was referenced Mar 13, 2021
Merged
This was referenced Mar 15, 2021
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: This PR addresses an issue with the
aws-amplify-react-nativewithAuthenticatorHOC where, following the implementation outlined in our documentation, a user provided theme would be ignored.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.