-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amazon-cognito-identity-js): update podspec dependency #7873
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7873 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 215 215
Lines 13470 13470
Branches 2645 2645
=======================================
Hits 10004 10004
Misses 3268 3268
Partials 198 198
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
#7747
Description of changes:
Xcode 12 will fail to build apps using
amazon-cognito-identity-js
when no other module in the project has an explicit dependency onReact-Core
. Based on the guidance from facebook/react-native#29633 (comment), we need to update our dependency in the podspec fromReact
toReact-Core
, sinceReact
is essentially an umbrella dependency.I have tested this locally with verdaccio to verify the update does NOT cause any breaking changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.