Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: New issue form structure cleanup #7869

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

siegerts
Copy link
Contributor

@siegerts siegerts commented Mar 3, 2021

Description of changes:

  • Clean up spacing
  • Rearrange sections
  • Use placeholder vs value for optional configuration code inputs
  • Remove note on CLI repo - can add in future, if needed

Issue #, if available:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Rearrange sections
- Use placeholder vs value for optional configuration inputs
- Remove note on CLI repo - can add in future, if needed
@siegerts siegerts requested a review from sammartinez as a code owner March 3, 2021 18:40
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #7869 (946187e) into main (715aa7e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7869   +/-   ##
=======================================
  Coverage   74.26%   74.26%           
=======================================
  Files         215      215           
  Lines       13470    13470           
  Branches     2645     2645           
=======================================
  Hits        10004    10004           
  Misses       3268     3268           
  Partials      198      198           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715aa7e...946187e. Read the comment docs.

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants