Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazon-cognito-identity-js): update sendMFACode callback type #7801

Merged
merged 5 commits into from
Mar 11, 2021

Conversation

mk0sojo
Copy link
Contributor

@mk0sojo mk0sojo commented Feb 22, 2021

_Issue #7793

_Description of changes: Added userConfirmationNecessary to sendMFACode onSuccess in typedefinition

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@amhinson amhinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update @mk0sojo! 🙏

I do see that the 2nd argument to the onSuccess callback can sometimes return a boolean value for UserConfirmationNecessary, so this update makes sense.

return callback.onSuccess(this.signInUserSession);

if (dataConfirm.UserConfirmationNecessary === true) {
return callback.onSuccess(
this.signInUserSession,
dataConfirm.UserConfirmationNecessary
);
}
return callback.onSuccess(this.signInUserSession);

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #7801 (114aaa5) into main (5a6cecd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7801   +/-   ##
=======================================
  Coverage   74.26%   74.26%           
=======================================
  Files         215      215           
  Lines       13470    13470           
  Branches     2645     2645           
=======================================
  Hits        10004    10004           
  Misses       3268     3268           
  Partials      198      198           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6cecd...114aaa5. Read the comment docs.

@amhinson amhinson changed the title Issue branch 7793 fix(amazon-cognito-identity-js): update sendMFACode callback type Mar 11, 2021
@amhinson amhinson merged commit 5cce7e6 into aws-amplify:main Mar 11, 2021
This was referenced Mar 13, 2021
This was referenced Mar 15, 2021
dgonsan pushed a commit to dgonsan/amplify-js that referenced this pull request Mar 18, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants