-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amazon-cognito-identity-js): update sendMFACode callback type #7801
Conversation
Forget your password? the text has a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update @mk0sojo! 🙏
I do see that the 2nd argument to the onSuccess
callback can sometimes return a boolean value for UserConfirmationNecessary
, so this update makes sense.
return callback.onSuccess(this.signInUserSession); |
amplify-js/packages/amazon-cognito-identity-js/src/CognitoUser.js
Lines 943 to 949 in 5a6cecd
if (dataConfirm.UserConfirmationNecessary === true) { | |
return callback.onSuccess( | |
this.signInUserSession, | |
dataConfirm.UserConfirmationNecessary | |
); | |
} | |
return callback.onSuccess(this.signInUserSession); |
Codecov Report
@@ Coverage Diff @@
## main #7801 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 215 215
Lines 13470 13470
Branches 2645 2645
=======================================
Hits 10004 10004
Misses 3268 3268
Partials 198 198 Continue to review full report at Codecov.
|
…s-amplify#7801) * Added userConfirmationNecessary to sendMFACode
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
_Issue #7793
_Description of changes: Added userConfirmationNecessary to sendMFACode onSuccess in typedefinition
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.