Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage protected level #780

Merged
merged 5 commits into from
May 18, 2018

Conversation

powerful23
Copy link
Contributor

Issue #, if available:
To allow users to get others' protected files by specifying the identity id
Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@powerful23 powerful23 requested review from mbahar and nidsharm as code owners May 2, 2018 21:13
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Comments on docs and we can talk about the use case of list files on protected prefix.

level: 'protected',
identityId: 'xxxxxxx' // the identityId of that user
})
.then(result => console.log(result))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add extra space to be consistent with the other example

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other methods didn't have an example: put, list and remove.

Maybe another use case could be listing on protected prefix (to read all the identityId under that prefix). We can discuss offline

@codecov-io
Copy link

codecov-io commented May 3, 2018

Codecov Report

Merging #780 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage    87.3%   87.36%   +0.05%     
==========================================
  Files          77       77              
  Lines        3670     3671       +1     
  Branches      696      697       +1     
==========================================
+ Hits         3204     3207       +3     
+ Misses        443      442       -1     
+ Partials       23       22       -1
Impacted Files Coverage Δ
packages/aws-amplify/src/Storage/Storage.ts 97.74% <100%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b86c0...cabf83a. Read the comment docs.

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice!

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants