-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage protected level #780
Storage protected level #780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Comments on docs and we can talk about the use case of list files on protected prefix.
level: 'protected', | ||
identityId: 'xxxxxxx' // the identityId of that user | ||
}) | ||
.then(result => console.log(result)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add extra space to be consistent with the other example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other methods didn't have an example: put, list and remove.
Maybe another use case could be listing on protected prefix (to read all the identityId under that prefix). We can discuss offline
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
==========================================
+ Coverage 87.3% 87.36% +0.05%
==========================================
Files 77 77
Lines 3670 3671 +1
Branches 696 697 +1
==========================================
+ Hits 3204 3207 +3
+ Misses 443 442 -1
+ Partials 23 22 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice!
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
To allow users to get others' protected files by specifying the identity id
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.