use NetworkError code in aws-cognito-identity #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return NetworkError Code in error callback in Client.js
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
=======================================
Coverage 87.03% 87.03%
=======================================
Files 74 74
Lines 3495 3495
Branches 668 668
=======================================
Hits 3042 3042
Misses 436 436
Partials 17 17Continue to review full report at Codecov.
|
mlabieniec
approved these changes
Apr 24, 2018
This was referenced Mar 14, 2021
Merged
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
it related to PR : #605
Description of changes:
Minor change :
return "NetworkError" code inside the error callback in client.js on network error instead of Error code "Error".
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.