Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isAllResponse to custom authorizer request in API #664

Merged
merged 5 commits into from
May 10, 2018

Conversation

Quelu
Copy link
Contributor

@Quelu Quelu commented Apr 16, 2018

Allow to get the full response from an API call with a custom authorizer

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Apr 16, 2018

Codecov Report

Merging #664 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   87.72%   87.72%           
=======================================
  Files          75       75           
  Lines        3593     3593           
  Branches      683      683           
=======================================
  Hits         3152     3152           
  Misses        419      419           
  Partials       22       22
Impacted Files Coverage Δ
packages/aws-amplify/src/API/RestClient.ts 93.25% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65003be...9be231f. Read the comment docs.

@Quelu
Copy link
Contributor Author

Quelu commented Apr 23, 2018

Would be awesome if someone could merge and release this.
This is a blocking feature for my project as we use a custom authorizer and we need to get the status code from the full response

@Quelu
Copy link
Contributor Author

Quelu commented Apr 30, 2018

@manueliglesias / @elorzafe I really need this in the next release, could you please review this ?
This will correct a regression from a previous update. We were able to pass the isAllResponse parameter to a custom authorizer API call. This feature is still here but the parameter has been remove from the _request method call.

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants