Upgrade version of x11-clipboard library to 0.6 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
iceiix
added a commit
to iceiix/stevenarella
that referenced
this pull request
Jul 30, 2022
iceiix
added a commit
to iceiix/stevenarella
that referenced
this pull request
Jul 31, 2022
benjaminedwardwebb
added a commit
to benjaminedwardwebb/dmenu-rs
that referenced
this pull request
Oct 22, 2022
The rust-clipboard project's maintenance status is [unclear][1]. It pulls in an old version of [ruxt-xcb][2]. This old version has a [security issue][3]. It also has a complex build that caused failures I could not debug when building dmenu-rs with nix. There is an [open PR][4] to rust-clipboard that updates the X11 and XCB dependencies with a minimal changeset, resolving this issue. This commit updates dmenu-rs's rust-clipboard dependency to point to the fix in the open PR, located on the upgrade-x11 branch of xliiv's fork. You can find similar discussion in an unrelated project [here][5]. [1]: aweinstock314/rust-clipboard#91 [2]: https://github.com/rust-x-bindings/rust-xcb/tree/v0.8.2 [3]: aweinstock314/rust-clipboard#90 [4]: aweinstock314/rust-clipboard#89 [5]: iceiix/stevenarella#701
benjaminedwardwebb
added a commit
to benjaminedwardwebb/dmenu-rs
that referenced
this pull request
Nov 12, 2022
The rust-clipboard project's maintenance status is [unclear][1]. It pulls in an old version of [ruxt-xcb][2]. This old version has a [security issue][3]. It also has a complex build that caused failures I could not debug when building dmenu-rs with nix. There is an [open PR][4] to rust-clipboard that updates the X11 and XCB dependencies with a minimal changeset, resolving this issue. This commit updates dmenu-rs's rust-clipboard dependency to point to the fix in the open PR, located on the upgrade-x11 branch of xliiv's fork. You can find similar discussion in an unrelated project [here][5]. [1]: aweinstock314/rust-clipboard#91 [2]: https://github.com/rust-x-bindings/rust-xcb/tree/v0.8.2 [3]: aweinstock314/rust-clipboard#90 [4]: aweinstock314/rust-clipboard#89 [5]: iceiix/stevenarella#701
benjaminedwardwebb
added a commit
to benjaminedwardwebb/dmenu-rs
that referenced
this pull request
Nov 12, 2022
The rust-clipboard project's maintenance status is [unclear][1]. It pulls in an old version of [ruxt-xcb][2]. This old version has a [security issue][3]. It also has a complex build that caused failures I could not debug when building dmenu-rs with nix. There is an [open PR][4] to rust-clipboard that updates the X11 and XCB dependencies with a minimal changeset, resolving this issue. This commit updates dmenu-rs's rust-clipboard dependency to point to the fix in the open PR, located on the upgrade-x11 branch of xliiv's fork. You can find similar discussion in an unrelated project [here][5]. [1]: aweinstock314/rust-clipboard#91 [2]: https://github.com/rust-x-bindings/rust-xcb/tree/v0.8.2 [3]: aweinstock314/rust-clipboard#90 [4]: aweinstock314/rust-clipboard#89 [5]: iceiix/stevenarella#701
benjaminedwardwebb
approved these changes
Nov 13, 2022
There was a problem hiding this comment.
I believe this also resolves #90.
@aweinstock314 @SimonSapin @nox any reason this can't be merged?
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88