Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests regressions! #134

Closed
carlos4242 opened this issue Mar 6, 2019 · 6 comments
Closed

Unit tests regressions! #134

carlos4242 opened this issue Mar 6, 2019 · 6 comments
Labels
has-local-patch A patch exists but has not been applied to upstream LLVM

Comments

@carlos4242
Copy link

I've just run the unit tests on avr-rust-2019-01-18 and I'm getting regressions?

Testing Time: 2.56s


Failing Tests (4):
LLVM :: CodeGen/AVR/call.ll
LLVM :: CodeGen/AVR/directmem.ll
LLVM :: CodeGen/AVR/div.ll
LLVM :: CodeGen/AVR/rem.ll

Expected Passes : 117
Expected Failures : 3
Unexpected Failures: 4

@carlos4242
Copy link
Author

carlos4242 commented Mar 10, 2019

These are all fixed by avr-rust/llvm#10.

@carlos4242
Copy link
Author

LABEL AS: has local patch

@hercek
Copy link

hercek commented Mar 15, 2019

How do you run the unit tests (except running them for each file manually)?
llvm-lit does not work on my build. It does not have python variable llvm_config defined probably becase rust/src/llvm/test/lit.site.cfg.py.in is not processed to lit.site.cfg.py.

@carlos4242
Copy link
Author

carlos4242 commented Mar 15, 2019 via email

@hercek
Copy link

hercek commented Mar 16, 2019

Thanks. That is it. When you let rust build system to build llvm then it does not build llvm-lit and trying to run it from build/utils/llvm-lit does not work as I described before.

@shepmaster shepmaster added the has-local-patch A patch exists but has not been applied to upstream LLVM label Apr 13, 2019
@dylanmckay
Copy link
Member

Since fixed in LLVM trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-local-patch A patch exists but has not been applied to upstream LLVM
Projects
None yet
Development

No branches or pull requests

4 participants