Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browsable API response error handling is brittle #35

Closed
avoidwork opened this issue Apr 1, 2015 · 1 comment
Closed

Browsable API response error handling is brittle #35

avoidwork opened this issue Apr 1, 2015 · 1 comment
Assignees
@avoidwork
Labels
bug

Comments

@avoidwork
Copy link
Owner

The following line doesn't handle String responses:

var data = JSON.parse( e.message ) || { error: "An error has occurred" };
@avoidwork avoidwork added the bug label Apr 1, 2015
@avoidwork avoidwork self-assigned this Apr 1, 2015
@avoidwork
Copy link
Owner Author

This issue can be triggered by POSTing an invalid payload to https://api.workschedulr.com/login

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avoidwork avoidwork

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@avoidwork