Reducing utility.sort() & fixing a reference error

avoidwork · Dec 8, 2020 · 7d42d3a · 7d42d3a
1 parent 3cfaffc
commit 7d42d3a
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/lib/utility.js b/lib/utility.js
@@ -636,7 +636,7 @@ function hypermedia (req, res, rep) {
 }
 
 function sort (arg, req) {
-	let output;
+	let output = clone(arg);
 
 	if (typeof req.parsed.search === "string" && req.parsed.searchParams.has("order_by") && Array.isArray(arg)) {
 		const type = typeof arg[0];
@@ -645,17 +645,13 @@ function sort (arg, req) {
 			const args = req.parsed.searchParams.getAll("order_by").filter(i => i !== "desc").join(", ");
 
 			if (args.length > 0) {
-				output = keysort(clone(arg), args);
+				output = keysort(output, args);
 			}
-		} else {
-			output = clone(arg);
 		}
 
 		if (req.parsed.search.includes("order_by=desc")) {
 			output = output.reverse();
 		}
-	} else {
-		output = arg;
 	}
 
 	return output;