-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMimage get --debug option #6061
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6061 +/- ##
==========================================
- Coverage 54.46% 54.44% -0.03%
==========================================
Files 202 202
Lines 21883 21890 +7
==========================================
- Hits 11919 11918 -1
- Misses 9964 9972 +8 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
a9424ca
to
50527e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @richtja ,
Thanks for working on this. While this gets the most important thing done, that is, info about a failure, IMO a --debug
option should:
- Also work during success cases, that is, it should show what's going on whether the operation is succeeding or failing
- Should not crash the application
Have you tried adding various logging entries to the avocado.utils.vmimage
module and making them visible when --debug
is given?
c5d30e1
to
9635303
Compare
Hi @clebergnu, thanks for your review. I have changed this PR to use logging instead of raising errors. Please have a look. |
This commit adds logs to the vmimage utility. After this change, vmimage will log information about ImageProviderErrors. Reference: avocado-framework#6051 Signed-off-by: Jan Richter <[email protected]>
This commit adds a new option to `vmimage get` feature called `debug`. It brings possibility to run vmimage command in debug mode to get more detailed information about possible failures. In debug mode, all exceptions caused by vmimage utility will be logged to console. That should provide enough information for further debugging of possible issues. Reference: avocado-framework#6051 Signed-off-by: Jan Richter <[email protected]>
9635303
to
7420e5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This commit adds a new option to
vmimage get
feature calleddebug
. It brings possibility to run vmimage command in debug mode to get more detailed information about possible failures. In debug mode, all exceptions caused by vmimage utility will be raised to console. That should provide enough information for further debugging of possible issues.Reference: #6051
vmimage get
without debug:vmimage get
with debug: