Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location issue #1558

Closed
mahalakshme opened this issue Dec 20, 2024 · 6 comments
Closed

Location issue #1558

mahalakshme opened this issue Dec 20, 2024 · 6 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Dec 20, 2024

https://avni.freshdesk.com/a/tickets/5008

Context:

As part of this ticket, some location table updates via script was run

Steps to reproduce:

env: prod, login to dinesh@jscs, you will find the below issues, that doesn't exist in prerelease

  1. After fast sync the original username is not reset. Potential issue of all sync happening with this name
  2. During edit of registration, location selected is not getting displayed
  3. In the filter, even before selecting district and block, all villages are getting displayed

https://drive.google.com/file/d/1CBlKLOdaozTQEvv0ik6geOdeHRb25bmx/view?usp=drive_link

Need to fix this:

  • We periodically do client migrations, run db scripts on server and users do fast sync. Presence of such inconsistent data might lead to unexpected behaviour.
  • There might be more hidden issues.
  • Soon new HWC location type will get introduced in the prod JSCS, and this inconsistent data, might aggravate the issue

AC:

Currently the prerelease or staging JSCS doesn't have the issue that prod JSCS has. Hence finally in prod need to work like the below:

  1. On clicking Edit of registration, selected locations should get displayed
  2. On clicking Filter, only after selecting the highest location filter - District -> the rest of the location types should get displayed
  3. On completion of fast sync, with login as dinesh@jscs -> it should show dinesh@jscs and not some other username
@mahalakshme mahalakshme converted this from a draft issue Dec 20, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Dec 20, 2024
@himeshr himeshr moved this from Ready to In Progress in Avni Product Dec 23, 2024
@himeshr himeshr self-assigned this Dec 23, 2024
@himeshr
Copy link
Contributor

himeshr commented Dec 23, 2024

The root cause of issue "After fast sync the original username is not reset. Potential issue of all sync happening with this name" is as per card

Confirmed that the issue doesn't happen if we clear emulator storage and do sync.

@himeshr
Copy link
Contributor

himeshr commented Dec 23, 2024

Resolution for AC:

  1. During create / edit of registration issue ==> Resync of "Location Mapping" resolves the issue
  2. In Filter screen or Subject Search screen issue ==> Resync of "Location Mapping" resolves the issue
  3. Old user name present ==> Resolved as part of Fastsync locale mapping issue #1552

Data-fix

Resync of "Location Mapping" shall be achieved by updating lastModifiedDateTime for all LocationLocationMapping table entries for JSCS org done as part of commit https://github.com/avniproject/data-fixes/commit/98a2edb3a9203baa24cfac3b3a2c62352708c9a4

@himeshr himeshr moved this from In Progress to Code Review Ready in Avni Product Dec 23, 2024
@himeshr
Copy link
Contributor

himeshr commented Dec 23, 2024

Patch to force sync all LocationMappings on client dev apk without modifying Server or Client DBs..
#1558___Force_fetch_LocationMapping.patch

@mahalakshme mahalakshme moved this from Code Review Ready to In Code Review in Avni Product Dec 24, 2024
@mahalakshme mahalakshme moved this from In Code Review to Code Review Ready in Avni Product Dec 24, 2024
@mahalakshme mahalakshme moved this from Code Review Ready to In Code Review in Avni Product Dec 24, 2024
@mahalakshme mahalakshme moved this from In Code Review to QA Ready in Avni Product Dec 24, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Dec 25, 2024
@mahalakshme
Copy link
Contributor Author

@AchalaBelokar this is Tech QA card

@mahalakshme
Copy link
Contributor Author

@himeshr you can itself pickup this card and get it to done, since we are not much people now.

@himeshr
Copy link
Contributor

himeshr commented Dec 25, 2024

Ran the script and later on verified that following issues were resolved:

  • During create of registration, child locations are displayed before a parent is selected
  • During edit of registration, location selected is not getting displayed
  • In Individual Filter screen or Subject Search screen, child locations are displayed before a parent is selected

JSCS location mapping update transaction logs

@himeshr himeshr closed this as completed Dec 25, 2024
@github-project-automation github-project-automation bot moved this from In QA to Done in Avni Product Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants