Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle-size #29

Closed
domhaas opened this issue Dec 5, 2024 · 2 comments · Fixed by #31
Closed

bundle-size #29

domhaas opened this issue Dec 5, 2024 · 2 comments · Fixed by #31

Comments

@domhaas
Copy link
Contributor

domhaas commented Dec 5, 2024

Hey there,

I got some issue while deploying an application. It seems like lodash as dependency of useInertiaForm is blowing the bundle-size to the limit:

image

Issue on my side, or are there some things we could do to optimize it here? tree-shakin might be a point.

Thanks!

Cheers,
Dom

@aviemet
Copy link
Owner

aviemet commented Dec 6, 2024

I'll be honest, I'm not very familiar or comfortable with publishing packages or optimizing bundle sizes. If you have any suggestions I'd love to get them, I'm currently trying some things out on the bundle branch. So far I've tried moving all non dev-dependencies into peerDependencies, but when building, the bundle size doesn't change much at all for me.

I'm going to keep trying to optimize, and I'll make another release in a few days once I've tried some things out. Do let me know if you have any tips though.

@aviemet aviemet linked a pull request Dec 6, 2024 that will close this issue
@domhaas
Copy link
Contributor Author

domhaas commented Dec 6, 2024

I'll be honest, I'm not very familiar or comfortable with publishing packages or optimizing bundle sizes. If you have any suggestions I'd love to get them, I'm currently trying some things out on the bundle branch. So far I've tried moving all non dev-dependencies into peerDependencies, but when building, the bundle size doesn't change much at all for me.

I'm going to keep trying to optimize, and I'll make another release in a few days once I've tried some things out. Do let me know if you have any tips though.

Thanks @aviemet for your reply,

I'm not really a professional with build processes either - but I think I already have a clue.
I'll get back to you in a few days with a change request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants