Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

av adds metadata to PRs that may show up in commit messages #347

Open
sarthak opened this issue Jun 21, 2024 · 1 comment
Open

av adds metadata to PRs that may show up in commit messages #347

sarthak opened this issue Jun 21, 2024 · 1 comment

Comments

@sarthak
Copy link

sarthak commented Jun 21, 2024

For stacked PRs managed through av, created using av pr create, following text is automatically added to PR description.

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
\```
{"parent":"main","parentHead":"","trunk":"main"}
\```
-->

In my repository setup, all PR merges are handled automatically through a squash-and-merge strategy which copies the PR description over as the squash commit message while merging the PR. This means that these metadata comments show up in my merged commits as well.

Is it possible to manage this metadata in the local db, instead of PR description to avoid this issue?

@jainankit
Copy link
Contributor

Hi @sarthak thanks for reaching out. This metadata is used by Aviator server for managing the MergeQueue. Currently we don't have a way to support this on the backend without the metadata.

We can potentially accept a contribution to introduce an av config to disable this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants