-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IconKey): adding IconKey to library #584
Conversation
WalkthroughThis update introduces a new icon component called Changes
Sequence DiagramsIconKey Component RenderingsequenceDiagram
participant User
participant IconKey Component
participant Font Awesome Library
User->>IconKey Component: Include IconKey component
IconKey Component->>Font Awesome Library: Request for key icon
Font Awesome Library-->>IconKey Component: Return key icon data
IconKey Component-->>User: Render key icon with specified properties
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
Bundle Size (components)
Overall bundle size: 82.65 KB (+4 B 0.00%) Bundle Size (form components)
Overall bundle size: 49.33 KB (+5 B +0.01%) Bundle Size (system)
Overall bundle size: 54.06 KB (+7 B +0.01%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
packages/ui-icons/lib/icons/svg/key.svg
is excluded by!**/*.svg
Files selected for processing (4)
- packages/ui-icons/lib/icons/config.json (1 hunks)
- packages/ui-icons/src/components/Icons/IconKey.tsx (1 hunks)
- packages/ui-icons/src/components/Icons/tests/Icons.test.tsx (3 hunks)
- packages/ui-icons/src/components/index.ts (2 hunks)
Files skipped from review due to trivial changes (3)
- packages/ui-icons/lib/icons/config.json
- packages/ui-icons/src/components/Icons/IconKey.tsx
- packages/ui-icons/src/components/index.ts
Additional comments not posted (3)
packages/ui-icons/src/components/Icons/__tests__/Icons.test.tsx (3)
20-20
: Import statement change approved.The addition of
IconKey
to the import statement is correct and necessary for testing.
277-283
: Addition ofIconKey
to the test suite approved.The addition of
IconKey
to the test suite follows the existing pattern and ensures it is tested alongside other icons.
315-315
: Addition oficon-key
to the dataTestId array approved.The addition of
icon-key
to the dataTestId array ensures it is included in the loop that verifies the rendered output for each icon.
🤖 I have created a release *beep* *boop* --- <details><summary>ui-icons: 1.11.0</summary> ## [1.11.0](ui-icons-v1.10.0...ui-icons-v1.11.0) (2024-07-14) ### Features * **IconKey:** adding IconKey to library ([#584](#584)) ([3589daf](3589daf)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
PR Type
Enhancement, Tests
Description
IconKey
component with SVG paths and properties.IconKey
component in the index file.IconKey
component in the generic icons prop tests.IconKey
component.Changes walkthrough 📝
IconKey.tsx
Add new IconKey component with SVG paths
packages/ui-icons/src/components/Icons/IconKey.tsx
IconKey
component.className
,viewBox
,spacing
,title
, andmonotone
.index.ts
Export new IconKey component
packages/ui-icons/src/components/index.ts
IconKey
component.config.json
Add configuration for new IconKey component
packages/ui-icons/lib/icons/config.json
IconKey
component.name
,title
, andmonotone
.Icons.test.tsx
Add tests for new IconKey component
packages/ui-icons/src/components/Icons/tests/Icons.test.tsx
IconKey
component.IconKey
in the generic icons prop tests.Summary by CodeRabbit
New Features
IconKey
component for displaying the key icon.Tests
IconKey
component.