Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Toggle): cannot toggle programmatically #569

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

aversini
Copy link
Collaborator

@aversini aversini commented Jul 1, 2024

Summary by CodeRabbit

  • New Features

    • Added a new story "Programmatically" to demonstrate toggling functionality.
  • Bug Fixes

    • Updated Toggle component to use checked instead of defaultChecked for better control of toggle state.

Copy link

coderabbitai bot commented Jul 1, 2024

Walkthrough

The recent updates include enhancements to the Toggle component and its story. The story now imports a Button component and demonstrates programmatic toggling. Additionally, the Toggle component's state handling has been optimized by switching from defaultChecked to checked for better control and consistency.

Changes

File Change Summary
`packages/documentation/src/Form/Toggle... Updated the import statement to include Button, and added the Programmatically story for the Toggle component.
`packages/ui-form/src/components/Toggle... Changed the defaultChecked attribute to checked in the Toggle component to improve state handling.

Tip

Early access features: disabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Jul 1, 2024

Bundle Size (components)

Status File Size (Gzip) Limits
style.css 7.35 KB 8 KB
index.js 9.73 KB (+2 B +0.02%) 10 KB
vendor.js 65.36 KB 67 KB

Overall bundle size: 82.44 KB (+2 B 0.00%)
Overall status: ✅

Bundle Size (form components)

Status File Size (Gzip) Limits
index.js 4.84 KB (-9 B -0.18%) 20 KB
vendor.js 44.46 KB 67 KB

Overall bundle size: 49.3 KB (-9 B -0.02%)
Overall status: ✅

Bundle Size (system)

Status File Size (Gzip) Limits
style.css 7.66 KB (+1 B +0.01%) 8 KB
index.js 1.93 KB (+1 B +0.05%) 3 KB
vendor.js 44.46 KB 46 KB

Overall bundle size: 54.05 KB (+2 B 0.00%)
Overall status: ✅

@aversini aversini merged commit 9a6b39b into main Jul 1, 2024
6 checks passed
@aversini aversini deleted the fix(Toggle)-cannot-toggle-programmatically branch July 1, 2024 15:28
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 40c5513 and 1bc023e.

Files selected for processing (2)
  • packages/documentation/src/Form/Toggle.stories.tsx (2 hunks)
  • packages/ui-form/src/components/Toggle/Toggle.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/ui-form/src/components/Toggle/Toggle.tsx
Additional comments not posted (2)
packages/documentation/src/Form/Toggle.stories.tsx (2)

2-2: Approved: Updated import statement.

The inclusion of Button from @versini/ui-components is necessary for the new story that allows toggling the component programmatically.


41-58: Approved: New story for programmatically toggling.

The implementation correctly demonstrates how to toggle the component state programmatically using a button. It might be beneficial to add a brief comment explaining the purpose of this example for future reference.

+ // Demonstrates programmatically toggling the Toggle component using a button.
export const Programmatically: Story<any> = (args) => {

@aversini aversini mentioned this pull request Jul 1, 2024
aversini added a commit that referenced this pull request Jul 1, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>ui-form: 1.3.5</summary>

##
[1.3.5](ui-form-v1.3.4...ui-form-v1.3.5)
(2024-07-01)


### Bug Fixes

* **Toggle:** cannot toggle programmatically
([#569](#569))
([9a6b39b](9a6b39b))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: aversini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant