-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Toggle): cannot toggle programmatically #569
Conversation
WalkthroughThe recent updates include enhancements to the Changes
Tip Early access features: disabledWe are currently testing the following features in early access:
Note:
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Bundle Size (components)
Overall bundle size: 82.44 KB (+2 B 0.00%) Bundle Size (form components)
Overall bundle size: 49.3 KB (-9 B -0.02%) Bundle Size (system)
Overall bundle size: 54.05 KB (+2 B 0.00%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- packages/documentation/src/Form/Toggle.stories.tsx (2 hunks)
- packages/ui-form/src/components/Toggle/Toggle.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/ui-form/src/components/Toggle/Toggle.tsx
Additional comments not posted (2)
packages/documentation/src/Form/Toggle.stories.tsx (2)
2-2
: Approved: Updated import statement.The inclusion of
Button
from@versini/ui-components
is necessary for the new story that allows toggling the component programmatically.
41-58
: Approved: New story for programmatically toggling.The implementation correctly demonstrates how to toggle the component state programmatically using a button. It might be beneficial to add a brief comment explaining the purpose of this example for future reference.
+ // Demonstrates programmatically toggling the Toggle component using a button. export const Programmatically: Story<any> = (args) => {
🤖 I have created a release *beep* *boop* --- <details><summary>ui-form: 1.3.5</summary> ## [1.3.5](ui-form-v1.3.4...ui-form-v1.3.5) (2024-07-01) ### Bug Fixes * **Toggle:** cannot toggle programmatically ([#569](#569)) ([9a6b39b](9a6b39b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: aversini <[email protected]>
Summary by CodeRabbit
New Features
Bug Fixes
checked
instead ofdefaultChecked
for better control of toggle state.