fix: refactor ButtonIcon to extract ButtonSort as a private component

[aversini]

Summary by CodeRabbit

• New Features
  • Introduced a new ButtonSort component for enhanced sorting functionality in tables.
• Refactor
  • Simplified the ButtonIcon component by removing the active prop and associated styling logic.
• Tests
  • Updated tests for ButtonIcon to reflect changes.
  • Added comprehensive tests for the new ButtonSort component to ensure it behaves correctly under various configurations.

[coderabbitai]

Walkthrough

The recent updates focus on refining the button components in the UI library. The ButtonIcon component has been simplified by removing the active prop and its related logic, streamlining its structure. A new ButtonSort component has been introduced to handle sorting functionalities with customizable features. Corresponding changes in type definitions and tests reflect these modifications, enhancing clarity and functionality in the component library.

Changes

File Path	Change Summary
.../Button/ButtonIcon.tsx	Simplified by removing the active prop and the wrapping div. Now renders directly as a button.
.../Button/ButtonTypes.d.ts, .../ButtonIcon.test.tsx	Removed the active prop from type definitions and tests for active button states.
.../Table/Table.tsx	Updated to use the new ButtonSort for sorting functionalities in tables.
.../private/ButtonSort.tsx, .../private/ButtonSortTypes.d.ts	Introduced ButtonSort component with customizable props for sorting. Added new type definitions for ButtonSortProps.
.../private/__tests__/ButtonSort.test.tsx	Added tests for the new ButtonSort component, covering various modes, sizes, alignments, and states.

---

Recent Review Details

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 90529e8 and cc2ddeb.

Files selected for processing (7)

• packages/ui-components/src/components/Button/ButtonIcon.tsx (2 hunks)
• packages/ui-components/src/components/Button/ButtonTypes.d.ts (1 hunks)
• packages/ui-components/src/components/Button/tests/ButtonIcon.test.tsx (1 hunks)
• packages/ui-components/src/components/Table/Table.tsx (3 hunks)
• packages/ui-components/src/components/private/ButtonSort.tsx (1 hunks)
• packages/ui-components/src/components/private/ButtonSortTypes.d.ts (1 hunks)
• packages/ui-components/src/components/private/tests/ButtonSort.test.tsx (1 hunks)

Additional comments not posted (7)

packages/ui-components/src/components/private/ButtonSortTypes.d.ts (1)

3-9: The type definition for ButtonSortProps correctly extends ButtonIconProps and appropriately includes the active property to handle the active state of the button. Good use of TypeScript features to enhance component props.

packages/ui-components/src/components/Button/ButtonIcon.tsx (1)

57-68: The refactoring of the ButtonIcon component aligns with the PR objectives. The removal of the active prop and the direct rendering of the button element simplify the component structure and reduce unnecessary complexity.

packages/ui-components/src/components/Button/ButtonTypes.d.ts (1)

Line range hint 1-1: The update to the ButtonIconProps type definition correctly reflects the removal of the active prop, aligning with the changes in the ButtonIcon component. This simplifies the prop interface as intended.

packages/ui-components/src/components/private/ButtonSort.tsx (1)

7-97: The ButtonSort component is correctly implemented to handle sorting functionalities. The handling of the active state with conditional styling and the extension of ButtonIconProps align with the PR objectives to enhance modularity and maintainability.

packages/ui-components/src/components/Table/Table.tsx (1)

178-184: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [181-201]

The integration of the ButtonSort component within the TableCellSort component is correctly implemented. The props and conditional rendering align with the sorting functionality, enhancing the clarity and functionality of the table component.

packages/ui-components/src/components/Button/__tests__/ButtonIcon.test.tsx (1)

Line range hint 1-1: The updates to the ButtonIcon.test.tsx file correctly focus the tests on relevant modifiers, removing the tests related to the active state. This aligns with the changes in the ButtonIcon component and ensures the tests remain relevant and focused.

packages/ui-components/src/components/private/__tests__/ButtonSort.test.tsx (1)

1-1: The tests in the ButtonSort.test.tsx file are well-implemented, providing comprehensive coverage for the ButtonSort component. The tests correctly verify the behavior of the component under various conditions, ensuring its functionality is as expected.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Bundle Size (components)

Status	File	Size (Gzip)	Limits
✅	style.css	7.22 KB	8 KB
✅	index.js	9.29 KB (+76 B +0.81%)	20 KB
✅	vendor.js	65.16 KB	67 KB

Overall bundle size: 81.67 KB (+76 B +0.09%)
Overall status: ✅

Bundle Size (form components)

Status	File	Size (Gzip)	Limits
✅	index.js	4.75 KB	20 KB
✅	vendor.js	44.49 KB	67 KB

Overall bundle size: 49.24 KB
Overall status: ✅

Bundle Size (system)

Status	File	Size (Gzip)	Limits
✅	style.css	7.54 KB (+300 B +4.04%)	8 KB
✅	index.js	1.76 KB (+1 B +0.06%)	3 KB
✅	vendor.js	44.49 KB	46 KB

Overall bundle size: 53.8 KB (+301 B +0.55%)
Overall status: ✅