Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactoring all icons to use the size- Tailwind shortcut #505

Merged

Conversation

aversini
Copy link
Collaborator

@aversini aversini commented Apr 16, 2024

Summary by CodeRabbit

  • Documentation

    • Updated the Icons documentation to include changes in the layout and removal of certain stories.
  • Style

    • Changed default icon size class across various icon components for consistency.
  • Refactor

    • Updated icon components to use a new class name for default sizing, improving style consistency across the app.

Copy link

coderabbitai bot commented Apr 16, 2024

Walkthrough

The recent updates focus on standardizing icon sizes by changing defaultClassName from "h-5 w-5" to "size-5" across various components. Additionally, restructuring in Icons.stories.tsx includes adding a Card component, updating Table to compact, and removing an unnecessary story. These changes enhance consistency and readability in UI components.

Changes

File Path Change Summary
.../src/Icons/Icons.stories.tsx - Added Card component.
- Changed Table to Table compact.
- Moved content inside Card.
- Removed Mode story.
.../ui-icons/lib/buildIcons.js - Modified defaultClassName to "size-5" in SvgIcon.
.../ui-icons/src/components/Icons/Icon*.tsx - Updated defaultClassName from "h-5 w-5" to "size-5" in multiple icon components.

Recent Review Details

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 81ebffa and 7ddd5f9.
Files selected for processing (1)
  • packages/ui-icons/src/components/Icons/tests/Icons.test.tsx (1 hunks)
Additional comments not posted (1)
packages/ui-icons/src/components/Icons/__tests__/Icons.test.tsx (1)

32-32: Updated default icon size class to "size-5" aligns with the PR's objective to standardize icon sizes using Tailwind CSS.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Bundle Size (components)

Status File Size (Gzip) Limits
style.css 7.07 KB (+1 B +0.01%) 8 KB
index.js 9.09 KB (-4 B -0.04%) 20 KB
vendor.js 65.16 KB 67 KB

Overall bundle size: 81.32 KB (-3 B 0.00%)
Overall status: ✅

Bundle Size (form components)

Status File Size (Gzip) Limits
index.js 4.75 KB (+5 B +0.10%) 20 KB
vendor.js 44.49 KB 67 KB

Overall bundle size: 49.25 KB (+5 B +0.01%)
Overall status: ✅

Bundle Size (system)

Status File Size (Gzip) Limits
style.css 7.38 KB (+134 B +1.81%) 8 KB
index.js 1.76 KB (+1 B +0.06%) 3 KB
vendor.js 44.49 KB 46 KB

Overall bundle size: 53.63 KB (+135 B +0.25%)
Overall status: ✅

@aversini aversini merged commit ebac848 into main Apr 16, 2024
5 checks passed
@aversini aversini deleted the feat-refactoring-all-icons-to-use-the-size--Tailwind-shortcut branch April 16, 2024 16:27
@aversini aversini mentioned this pull request Apr 16, 2024
aversini added a commit that referenced this pull request Apr 16, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>ui-components: 5.17.0</summary>

##
[5.17.0](ui-components-v5.16.1...ui-components-v5.17.0)
(2024-04-16)


### Features

* **Table:** better sort indicator when a column is sorted
([#507](#507))
([e52ca48](e52ca48))
</details>

<details><summary>ui-icons: 1.7.0</summary>

##
[1.7.0](ui-icons-v1.6.0...ui-icons-v1.7.0)
(2024-04-16)


### Features

* refactoring all icons to use the size- Tailwind shortcut
([#505](#505))
([ebac848](ebac848))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: aversini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant