Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ButtonIcon): adding support for prop "align" #498

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

aversini
Copy link
Collaborator

@aversini aversini commented Apr 15, 2024

Summary by CodeRabbit

  • New Features

    • Added an align property to the ButtonIcon component to customize alignment with a default of "center".
  • Tests

    • Implemented new test cases to verify the alignment functionality of the ButtonIcon component.

Copy link

coderabbitai bot commented Apr 15, 2024

Walkthrough

The recent updates focus on enhancing the ButtonIcon component by introducing an align property for customizable alignment. This new feature enables users to align the button icon as needed, affecting its appearance and layout. The changes span across component definition, styling logic, utility functions, and even test cases to ensure alignment functionality works correctly.

Changes

File Path Change Summary
.../Button/ButtonIcon.tsx, .../Button/ButtonTypes.d.ts Added align prop to ButtonIcon with default "center". Updated ButtonIconProps in ButtonTypes.d.ts.
.../Button/__tests__/ButtonIcon.test.tsx Added test cases for verifying alignment classes based on align prop.
.../Button/utilities.ts Extended getButtonClasses with align property for alignment options.
.../Components/ButtonIcon.stories.tsx Added align property options to ButtonIcon component's story configuration.

Recent Review Details

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 35bb80e and 49e093e.
Files selected for processing (1)
  • packages/documentation/src/Components/ButtonIcon.stories.tsx (1 hunks)
Additional comments not posted (2)
packages/documentation/src/Components/ButtonIcon.stories.tsx (2)

84-84: The default setting for the align property is correctly implemented as "center".


87-90: The configuration of the align property in argTypes with radio options for "center", "left", and "right" is well-implemented, enhancing user interaction in the storybook.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Bundle Size (components)

Status File Size (Gzip) Limits
style.css 7.05 KB (+14 B +0.19%) 8 KB
index.js 8.6 KB (+50 B +0.57%) 20 KB
vendor.js 65.16 KB 67 KB

Overall bundle size: 80.81 KB (+64 B +0.08%)
Overall status: ✅

Bundle Size (form components)

Status File Size (Gzip) Limits
index.js 4.75 KB (-1 B -0.02%) 20 KB
vendor.js 44.49 KB 67 KB

Overall bundle size: 49.24 KB (-1 B 0.00%)
Overall status: ✅

Bundle Size (system)

Status File Size (Gzip) Limits
style.css 7.36 KB (+117 B +1.58%) 8 KB
index.js 1.76 KB (+1 B +0.06%) 3 KB
vendor.js 44.49 KB 46 KB

Overall bundle size: 53.62 KB (+118 B +0.22%)
Overall status: ✅

@aversini aversini merged commit 3a96dbe into main Apr 15, 2024
5 checks passed
@aversini aversini deleted the feat(ButtonIcon)-adding-support-for-prop-align- branch April 15, 2024 15:51
@aversini aversini mentioned this pull request Apr 15, 2024
aversini added a commit that referenced this pull request Apr 15, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>ui-components: 5.15.0</summary>

##
[5.15.0](ui-components-v5.14.5...ui-components-v5.15.0)
(2024-04-15)


### Features

* **ButtonIcon:** adding support for prop "align"
([#498](#498))
([3a96dbe](3a96dbe))
</details>

<details><summary>ui-icons: 1.6.0</summary>

##
[1.6.0](ui-icons-v1.5.0...ui-icons-v1.6.0)
(2024-04-15)


### Features

* adding IconSort
([#500](#500))
([9f8b17b](9f8b17b))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: aversini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant